[Scummvm-git-logs] scummvm master -> 09bf38c1207aa32b9966e8642ee60e2186e15789

mduggan mgithub at guarana.org
Sat May 9 13:02:42 UTC 2020


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
09bf38c120 ULTIMA: Add missing initializers for coverity


Commit: 09bf38c1207aa32b9966e8642ee60e2186e15789
    https://github.com/scummvm/scummvm/commit/09bf38c1207aa32b9966e8642ee60e2186e15789
Author: Matthew Duggan (mgithub at guarana.org)
Date: 2020-05-09T22:02:27+09:00

Commit Message:
ULTIMA: Add missing initializers for coverity

Changed paths:
    engines/ultima/shared/core/mouse_cursor.cpp
    engines/ultima/shared/early/ultima_early.cpp
    engines/ultima/shared/engine/events.cpp
    engines/ultima/shared/gfx/popup.cpp
    engines/ultima/shared/maps/map_widget.h


diff --git a/engines/ultima/shared/core/mouse_cursor.cpp b/engines/ultima/shared/core/mouse_cursor.cpp
index b29face4e8..b45e3fbdb4 100644
--- a/engines/ultima/shared/core/mouse_cursor.cpp
+++ b/engines/ultima/shared/core/mouse_cursor.cpp
@@ -40,7 +40,7 @@ void MouseCursor::MouseCursorData::load(Common::SeekableReadStream &s) {
 
 /*-------------------------------------------------------------------*/
 
-MouseCursor::MouseCursor() {
+MouseCursor::MouseCursor() : _cursorId(-1) {
 /*
 	loadCursors();
 	_cursorId = -1;
diff --git a/engines/ultima/shared/early/ultima_early.cpp b/engines/ultima/shared/early/ultima_early.cpp
index 235ab9fcac..1927577cef 100644
--- a/engines/ultima/shared/early/ultima_early.cpp
+++ b/engines/ultima/shared/early/ultima_early.cpp
@@ -44,7 +44,7 @@ Shared::UltimaEarlyEngine *g_vm;
 namespace Shared {
 
 UltimaEarlyEngine::UltimaEarlyEngine(OSystem *syst, const UltimaGameDescription *gameDesc) :
-		UltimaEngine(syst, gameDesc) {
+		UltimaEngine(syst, gameDesc), _game(nullptr) {
 	g_vm = this;
 	_mouseCursor = nullptr;
 	_screen = nullptr;
diff --git a/engines/ultima/shared/engine/events.cpp b/engines/ultima/shared/engine/events.cpp
index 13a56479c2..d119e513cd 100644
--- a/engines/ultima/shared/engine/events.cpp
+++ b/engines/ultima/shared/engine/events.cpp
@@ -34,7 +34,7 @@ namespace Shared {
 
 EventsManager::EventsManager(EventsCallback *callback) : _callback(callback), _playTime(0),
 		_gameCounter(0), _frameCounter(0), _priorFrameCounterTime(0), _buttonsDown(0),
-		_specialButtons(0) {
+		_specialButtons(0), _priorFrameTime(0) {
 }
 
 void EventsManager::showCursor() {
diff --git a/engines/ultima/shared/gfx/popup.cpp b/engines/ultima/shared/gfx/popup.cpp
index e333226710..c0b2ce97ee 100644
--- a/engines/ultima/shared/gfx/popup.cpp
+++ b/engines/ultima/shared/gfx/popup.cpp
@@ -31,7 +31,7 @@ BEGIN_MESSAGE_MAP(Popup, VisualItem)
 	ON_MESSAGE(ShowMsg)
 END_MESSAGE_MAP()
 
-Popup::Popup(GameBase *game) : VisualItem(nullptr), _game(game), _respondTo(nullptr) {
+Popup::Popup(GameBase *game) : VisualItem(nullptr), _game(game), _respondTo(nullptr), _parentView(nullptr) {
 	game->addChild(this);
 }
 
diff --git a/engines/ultima/shared/maps/map_widget.h b/engines/ultima/shared/maps/map_widget.h
index 354469d2ff..b2833dda70 100644
--- a/engines/ultima/shared/maps/map_widget.h
+++ b/engines/ultima/shared/maps/map_widget.h
@@ -68,7 +68,7 @@ public:
 	/**
 	 * Constructor
 	 */
-	MapWidget(Game *game, MapBase *map) : _game(game), _map(map) {}
+	MapWidget(Game *game, MapBase *map) : _game(game), _map(map), _direction(DIR_NONE) {}
 	MapWidget(Game *game, MapBase *map, const Point &pt, Direction dir = DIR_NONE) : _game(game), _map(map), _position(pt), _direction(dir) {}
 	MapWidget(Game *game, MapBase *map, const Common::String &name, const Point &pt, Direction dir = DIR_NONE) :
 		_game(game), _map(map), _name(name), _position(pt), _direction(dir) {}




More information about the Scummvm-git-logs mailing list