[Scummvm-git-logs] scummvm master -> c952d34410bb714176c8ad3368830c58fa90d2ce

sev- sev at scummvm.org
Fri Oct 9 21:38:58 UTC 2020


This automated email contains information about 2 new commits which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
752f97f072 COMMON: Remove default implementation for OSystem::getScreenPixelBuffer()
c952d34410 TEST: Remove now unneeded library from dependencies


Commit: 752f97f072c65026e0376bf510f0ed3d678e619a
    https://github.com/scummvm/scummvm/commit/752f97f072c65026e0376bf510f0ed3d678e619a
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2020-10-09T23:31:43+02:00

Commit Message:
COMMON: Remove default implementation for OSystem::getScreenPixelBuffer()

Otherwise it brings circular dependency, and we anyway have it already
in modular-backend.cpp

Changed paths:
    common/system.h


diff --git a/common/system.h b/common/system.h
index 2a273ae82b..cee39bcd86 100644
--- a/common/system.h
+++ b/common/system.h
@@ -907,7 +907,7 @@ public:
 	 * The caller can then perform arbitrary graphics transformations
 	 * on the framebuffer (blitting, scrolling, etc.).
 	 */
-	virtual Graphics::PixelBuffer getScreenPixelBuffer() { return Graphics::PixelBuffer(); }
+	virtual Graphics::PixelBuffer getScreenPixelBuffer() = 0;
 
 	/**
 	 * Returns the currently set virtual screen height.


Commit: c952d34410bb714176c8ad3368830c58fa90d2ce
    https://github.com/scummvm/scummvm/commit/c952d34410bb714176c8ad3368830c58fa90d2ce
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2020-10-09T23:33:38+02:00

Commit Message:
TEST: Remove now unneeded library from dependencies

Changed paths:
    test/module.mk


diff --git a/test/module.mk b/test/module.mk
index ced4c1db04..9681bebb0d 100644
--- a/test/module.mk
+++ b/test/module.mk
@@ -6,7 +6,7 @@
 ######################################################################
 
 TESTS        := $(srcdir)/test/common/*.h $(srcdir)/test/audio/*.h $(srcdir)/test/math/*.h
-TEST_LIBS    := audio/libaudio.a graphics/libgraphics.a math/libmath.a common/libcommon.a
+TEST_LIBS    := audio/libaudio.a math/libmath.a common/libcommon.a
 
 ifeq ($(ENABLE_WINTERMUTE), STATIC_PLUGIN)
 	TESTS += $(srcdir)/test/engines/wintermute/*.h




More information about the Scummvm-git-logs mailing list