[Scummvm-git-logs] scummvm master -> f63025dc30ccfec1176f97551640014b2fa5740f

[yuv422]

This automated email contains information about 3 new commits which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
b657a83cf0 DRAGONS: Fixed dialog clearing in dance mini game
2dce756c50 DRAGONS: Allow quitting while talking to actors
f63025dc30 DRAGONS: Fixed coverity warning about negative indexing


Commit: b657a83cf02bcb2bdae8b51d2414f730ded7a5a3
    https://github.com/scummvm/scummvm/commit/b657a83cf02bcb2bdae8b51d2414f730ded7a5a3
Author: Eric Fry (yuv422 at users.noreply.github.com)
Date: 2020-09-07T21:46:39+10:00

Commit Message:
DRAGONS: Fixed dialog clearing in dance mini game

Changed paths:
    engines/dragons/minigame4.cpp


diff --git a/engines/dragons/minigame4.cpp b/engines/dragons/minigame4.cpp
index 3329d97b35..e246e55a75 100644
--- a/engines/dragons/minigame4.cpp
+++ b/engines/dragons/minigame4.cpp
@@ -23,6 +23,7 @@
 #include "dragons/actor.h"
 #include "dragons/dragons.h"
 #include "dragons/dragonini.h"
+#include "dragons/font.h"
 #include "dragons/talk.h"
 #include "dragons/inventory.h"
 #include "dragons/scene.h"
@@ -207,11 +208,7 @@ uint16 Minigame4::runDanceBattle() {
 			_vm->_talk->displayDialogAroundPoint(auStack2192, 0x27, 0xc, 0x3321, 0, 0x4C0C);
 			_vm->waitForFrames(0x10a);
 			_bruteActor->updateSequence(8);
-			//TODO
-//			if ((((DAT_8008e7e8 != 0) || (DAT_8008e848 != 0)) || (DAT_8008e844 != 0)) ||
-//				(DAT_8008e874 != 0)) {
-//				clearTextDialog((uint)DAT_8008e7e8, (uint)DAT_8008e844, (uint)DAT_8008e848, (uint)DAT_8008e874);
-//			}
+			_vm->_fontManager->clearText();
 			_flickerActor->waitUntilFlag8SetThenSet1000AndWaitFor4();
 			_flickerActor->updateSequence(7);
 			actorTalk(_flickerActor, 0, 0x4CC8);


Commit: 2dce756c50fcf8e2d44922149ab1223943798540
    https://github.com/scummvm/scummvm/commit/2dce756c50fcf8e2d44922149ab1223943798540
Author: Eric Fry (yuv422 at users.noreply.github.com)
Date: 2020-09-07T21:55:44+10:00

Commit Message:
DRAGONS: Allow quitting while talking to actors

Changed paths:
    engines/dragons/talk.cpp


diff --git a/engines/dragons/talk.cpp b/engines/dragons/talk.cpp
index 02e55f79aa..dc9e234fa5 100644
--- a/engines/dragons/talk.cpp
+++ b/engines/dragons/talk.cpp
@@ -713,6 +713,11 @@ TalkDialogEntry *Talk::displayTalkDialogMenu(Common::Array<TalkDialogEntry*> dia
 	LAB_800317a4:
 //		CheckIfCdShellIsOpen();
 	_vm->waitForFrames(1);
+
+	if (Engine::shouldQuit()) {
+		return nullptr;
+	}
+
 	y = 0;
 	x = 0;
 	if (hasDialogEntries) {


Commit: f63025dc30ccfec1176f97551640014b2fa5740f
    https://github.com/scummvm/scummvm/commit/f63025dc30ccfec1176f97551640014b2fa5740f
Author: Eric Fry (yuv422 at users.noreply.github.com)
Date: 2020-09-07T22:15:32+10:00

Commit Message:
DRAGONS: Fixed coverity warning about negative indexing

Changed paths:
    engines/dragons/sound.cpp
    engines/dragons/vabsound.cpp


diff --git a/engines/dragons/sound.cpp b/engines/dragons/sound.cpp
index 57cd47c1c8..8d0b2cf13b 100644
--- a/engines/dragons/sound.cpp
+++ b/engines/dragons/sound.cpp
@@ -434,7 +434,10 @@ void SoundManager::playSound(uint16 soundId, uint16 volumeId) {
 		if (handle) {
 			uint8 adjustedVolume = (uint8)((float)_sfxVolume * ((float)volume / 31));
 			debug(3, "Playing SFX: Master Volume %d  Adjusted Volume %d diff %f%%", _sfxVolume, adjustedVolume, 100 * ((float)volume / 31));
-			_vm->_mixer->playStream(Audio::Mixer::kSFXSoundType, handle, vabSound->getAudioStream(program, key), -1, adjustedVolume);
+			Audio::AudioStream *audioStream = vabSound->getAudioStream(program, key);
+			if (audioStream) {
+				_vm->_mixer->playStream(Audio::Mixer::kSFXSoundType, handle, audioStream, -1, adjustedVolume);
+			}
 		}
 	} else {
 		warning("Sound not found Program: %d, key %d", program, key);
diff --git a/engines/dragons/vabsound.cpp b/engines/dragons/vabsound.cpp
index 3f6cb63c4c..64313857e7 100644
--- a/engines/dragons/vabsound.cpp
+++ b/engines/dragons/vabsound.cpp
@@ -104,6 +104,9 @@ VabSound::~VabSound() {
 
 Audio::AudioStream *VabSound::getAudioStream(uint16 program, uint16 key) {
 	int16 vagID = getVagID(program, key);
+	if (vagID < 0) {
+		return nullptr;
+	}
 	int16 baseKey = getBaseToneKey(program, key);
 	int sampleRate = getAdjustedSampleRate(key, baseKey);
 	debug(3, "Playing program %d, Key %d, numTones: %d, vagID %d, vagOffset: %x, size: %x adjustedSampleRate: %d",