[Scummvm-git-logs] scummvm master -> 551a2deee9417b0e0097fe200e8f209bd9a3b786

digitall 547637+digitall at users.noreply.github.com
Fri Apr 2 09:14:26 UTC 2021


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
551a2deee9 ULTIMA: Fix GCC Compiler Warnings


Commit: 551a2deee9417b0e0097fe200e8f209bd9a3b786
    https://github.com/scummvm/scummvm/commit/551a2deee9417b0e0097fe200e8f209bd9a3b786
Author: D G Turner (digitall at scummvm.org)
Date: 2021-04-02T10:12:52+01:00

Commit Message:
ULTIMA: Fix GCC Compiler Warnings

The test for index being non-negative are redundant since the index
variable is unsigned integer.

Changed paths:
    engines/ultima/shared/std/containers.h


diff --git a/engines/ultima/shared/std/containers.h b/engines/ultima/shared/std/containers.h
index bd93bd2200..0f079bbdd7 100644
--- a/engines/ultima/shared/std/containers.h
+++ b/engines/ultima/shared/std/containers.h
@@ -263,7 +263,7 @@ class deque : public Common::List<VAL> {
 public:
 	VAL operator[](uint index) {
 		for (typename Common::List<VAL>::iterator it = this->begin();
-				it != this->end() && index >= 0; ++it, --index) {
+				it != this->end(); ++it, --index) {
 			if (index == 0)
 				return *it;
 		}




More information about the Scummvm-git-logs mailing list