[Scummvm-git-logs] scummvm master -> 71235358e3f7c205e514168b5756ea1944ef3323

sluicebox 22204938+sluicebox at users.noreply.github.com
Fri Apr 9 04:02:03 UTC 2021


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
71235358e3 SCI: Set port origin to even x coordinates only


Commit: 71235358e3f7c205e514168b5756ea1944ef3323
    https://github.com/scummvm/scummvm/commit/71235358e3f7c205e514168b5756ea1944ef3323
Author: sluicebox (22204938+sluicebox at users.noreply.github.com)
Date: 2021-04-08T21:01:03-07:00

Commit Message:
SCI: Set port origin to even x coordinates only

Fixes QFG1 (EGA) character allocation/stat screens drawing most of
their content one pixel to the right of where SSCI does.

Confirmed in disassembly of earliest and latest SCI16 interpreters.

This partially addresses bug #9593 regarding port drawing inaccuracies.

Changed paths:
    engines/sci/graphics/ports.cpp


diff --git a/engines/sci/graphics/ports.cpp b/engines/sci/graphics/ports.cpp
index bc813c27bd..6462b654c5 100644
--- a/engines/sci/graphics/ports.cpp
+++ b/engines/sci/graphics/ports.cpp
@@ -567,7 +567,7 @@ Port *GfxPorts::getPort() {
 }
 
 void GfxPorts::setOrigin(int16 left, int16 top) {
-	_curPort->left = left;
+	_curPort->left = left & 0xfffe; // SSCI clears the last bit
 	_curPort->top = top;
 }
 




More information about the Scummvm-git-logs mailing list