[Scummvm-git-logs] scummvm master -> 32c9ed7102afc86cd0bcb064f7ff1f2f0f9f289f
criezy
criezy at scummvm.org
Thu Apr 22 01:10:55 UTC 2021
This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .
Summary:
32c9ed7102 GUI: Do not list temporary targets in the launcher
Commit: 32c9ed7102afc86cd0bcb064f7ff1f2f0f9f289f
https://github.com/scummvm/scummvm/commit/32c9ed7102afc86cd0bcb064f7ff1f2f0f9f289f
Author: Thierry Crozat (criezy at scummvm.org)
Date: 2021-04-22T02:07:23+01:00
Commit Message:
GUI: Do not list temporary targets in the launcher
When starting a game from the command line for a target that had
not previously been added, a temporary target is created. When
subsequently returning to the launcher, it would attempt to
include that temporary target in list of games (and crash when
trying to get the path with an unknown key error as those
temporary targets do not have a path value set, which is actually
how I noticed the issue).
Changed paths:
gui/launcher.cpp
diff --git a/gui/launcher.cpp b/gui/launcher.cpp
index 94dcbc24e1..499f30b508 100644
--- a/gui/launcher.cpp
+++ b/gui/launcher.cpp
@@ -283,6 +283,10 @@ void LauncherDialog::updateListing() {
// Turn it into a list of pointers
Common::List<LauncherEntry> domainList;
for (ConfigManager::DomainMap::const_iterator iter = domains.begin(); iter != domains.end(); ++iter) {
+ // Do not list temporary targets added when starting a game from the command line
+ if (iter->_value.contains("id_came_from_command_line"))
+ continue;
+
String description;
if (!iter->_value.tryGetVal("description", description)) {
More information about the Scummvm-git-logs
mailing list