[Scummvm-git-logs] scummvm master -> 92931d41bf42740042a7a317b9ba09b491c0c896

ysj1173886760 42030331+ysj1173886760 at users.noreply.github.com
Sun Aug 1 09:02:37 UTC 2021


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
92931d41bf DIRECTOR: skip creating bitmap castmember when bbox is not available


Commit: 92931d41bf42740042a7a317b9ba09b491c0c896
    https://github.com/scummvm/scummvm/commit/92931d41bf42740042a7a317b9ba09b491c0c896
Author: ysj1173886760 (1173886760 at qq.com)
Date: 2021-08-01T17:02:03+08:00

Commit Message:
DIRECTOR: skip creating bitmap castmember when bbox is not available

Changed paths:
    engines/director/castmember.cpp


diff --git a/engines/director/castmember.cpp b/engines/director/castmember.cpp
index 49db40ba32..c323095a3d 100644
--- a/engines/director/castmember.cpp
+++ b/engines/director/castmember.cpp
@@ -181,6 +181,10 @@ Graphics::MacWidget *BitmapCastMember::createWidget(Common::Rect &bbox, Channel
 		return nullptr;
 	}
 
+	// skip creating widget when the bbox is not available, maybe we should create it using initialRect
+	if (!bbox.width() || !bbox.height())
+		return nullptr;
+
 	Graphics::MacWidget *widget = new Graphics::MacWidget(g_director->getCurrentWindow(), bbox.left, bbox.top, bbox.width(), bbox.height(), g_director->_wm, false);
 
 	// scale for drawing a different size sprite




More information about the Scummvm-git-logs mailing list