[Scummvm-git-logs] scummvm master -> 67605e1076518e1065067a555e6ebc48dd0a5e4a

NMIError 60350957+NMIError at users.noreply.github.com
Sun Aug 8 21:21:17 UTC 2021


This automated email contains information about 2 new commits which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
403e9bae34 ULTIMA8: Fix function call swapped parameters
67605e1076 COMMON: Add my name to the credits


Commit: 403e9bae34c942e47542bb955364680aebfe1dc1
    https://github.com/scummvm/scummvm/commit/403e9bae34c942e47542bb955364680aebfe1dc1
Author: Coen Rampen (crampen at gmail.com)
Date: 2021-08-08T23:21:12+02:00

Commit Message:
ULTIMA8: Fix function call swapped parameters

A call to the AudioProcess::stopSFX function seemed to have its parameters
swapped. This commit fixes this.

Changed paths:
    engines/ultima/ultima8/audio/audio_process.cpp


diff --git a/engines/ultima/ultima8/audio/audio_process.cpp b/engines/ultima/ultima8/audio/audio_process.cpp
index c2d29af5a0..3542a9a8fe 100644
--- a/engines/ultima/ultima8/audio/audio_process.cpp
+++ b/engines/ultima/ultima8/audio/audio_process.cpp
@@ -533,7 +533,7 @@ uint32 AudioProcess::I_playSFXCru(const uint8 *args, unsigned int argsize) {
 		AudioProcess *ap = AudioProcess::get_instance();
 		if (ap) {
 			// Crusader stops any existing item sounds before starting the next.
-			ap->stopSFX(item->getObjId(), -1);
+			ap->stopSFX(-1, item->getObjId());
 			ap->playSFX(sfxNum, 0x10, item->getObjId(), 0, true, PITCH_SHIFT_NONE, 0x80, false);
 		} else {
 			warning("I_playSFXCru Error: No AudioProcess");


Commit: 67605e1076518e1065067a555e6ebc48dd0a5e4a
    https://github.com/scummvm/scummvm/commit/67605e1076518e1065067a555e6ebc48dd0a5e4a
Author: Coen Rampen (crampen at gmail.com)
Date: 2021-08-08T23:21:12+02:00

Commit Message:
COMMON: Add my name to the credits

Changed paths:
    gui/credits.h


diff --git a/gui/credits.h b/gui/credits.h
index 8a93886cdd..56d8411a36 100644
--- a/gui/credits.h
+++ b/gui/credits.h
@@ -764,6 +764,8 @@ static const char *credits[] = {
 "C2""Return to launcher, savestate improvements, leak fixes, ... (GSoC 2008 task) (retired)",
 "C0""Robin Watts",
 "C2""ARM assembly routines for nice speedups on several ports; improvements to the sound mixer",
+"C0""Coen Rampen",
+"C2""Sound improvements",
 "",
 "",
 "C1""Website (code)",




More information about the Scummvm-git-logs mailing list