[Scummvm-git-logs] scummvm master -> 2782b1265dfe0626e0bd7b1933719e7864424124

antoniou79 a.antoniou79 at gmail.com
Sat Aug 14 08:22:46 UTC 2021


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
2782b1265d ANDROID: Remove set default gui_scale code


Commit: 2782b1265dfe0626e0bd7b1933719e7864424124
    https://github.com/scummvm/scummvm/commit/2782b1265dfe0626e0bd7b1933719e7864424124
Author: antoniou (a.antoniou79 at gmail.com)
Date: 2021-08-14T11:22:08+03:00

Commit Message:
ANDROID: Remove set default gui_scale code

This causes a crash, so it needs another approach

Changed paths:
    backends/platform/android/android.cpp


diff --git a/backends/platform/android/android.cpp b/backends/platform/android/android.cpp
index 7013cfb3d0..a00cf416c9 100644
--- a/backends/platform/android/android.cpp
+++ b/backends/platform/android/android.cpp
@@ -400,14 +400,6 @@ void OSystem_Android::initBackend() {
 		ConfMan.set("browser_lastpath", "/");
 	}
 
-	if (!ConfMan.hasKey("gui_scale")) {
-		// Until a proper scale detection is done (especially post PR https://github.com/scummvm/scummvm/pull/3264/commits/8646dfca329b6fbfdba65e0dc0802feb1382dab2),
-		// set scale by default to largest, if not set, and then let the user set it manually from the launcher -> Options -> Misc tab
-		// Otherwise the screen may default to very tiny and indiscernible text and be barely usable.
-		// TODO We need a proper scale detection for Android, see: (float) AndroidGraphicsManager::getHiDPIScreenFactor() in android/graphics.cpp
-		ConfMan.setInt("gui_scale", 0); // "Very large" (see gui/options.cpp)
-	}
-
 	// BUG: "transient" ConfMan settings get nuked by the options
 	// screen. Passing the savepath in this way makes it stick
 	// (via ConfMan.registerDefault() which is called from DefaultSaveFileManager constructor (backends/saves/default/default-saves.cpp))




More information about the Scummvm-git-logs mailing list