[Scummvm-git-logs] scummvm master -> 1dd7e98be39191d8fe9eb6c2045ac5dbcb9e80e1

digitall noreply at scummvm.org
Sat Dec 11 20:52:22 UTC 2021


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
1dd7e98be3 AUDIO: Fix GCC Warning by Removing Redundant Assertion from Mixer


Commit: 1dd7e98be39191d8fe9eb6c2045ac5dbcb9e80e1
    https://github.com/scummvm/scummvm/commit/1dd7e98be39191d8fe9eb6c2045ac5dbcb9e80e1
Author: D G Turner (digitall at scummvm.org)
Date: 2021-12-11T20:50:05Z

Commit Message:
AUDIO: Fix GCC Warning by Removing Redundant Assertion from Mixer

The output buffer size variable is unsigned so an assertion of
greater than or equal to zero will always be true, which generates
a type limits compiler warning.

Changed paths:
    audio/mixer.cpp


diff --git a/audio/mixer.cpp b/audio/mixer.cpp
index 1a3b32120a..e117216dd6 100644
--- a/audio/mixer.cpp
+++ b/audio/mixer.cpp
@@ -181,7 +181,6 @@ MixerImpl::MixerImpl(uint sampleRate, uint outBufSize)
 	: _mutex(), _sampleRate(sampleRate), _outBufSize(outBufSize), _mixerReady(false), _handleSeed(0), _soundTypeSettings() {
 
 	assert(sampleRate > 0);
-	assert(outBufSize >= 0);
 
 	for (int i = 0; i != NUM_CHANNELS; i++)
 		_channels[i] = nullptr;




More information about the Scummvm-git-logs mailing list