[Scummvm-git-logs] scummvm master -> 391c2f4a5d8e0ee35390c7d1de3358191e3387b2

sluicebox 22204938+sluicebox at users.noreply.github.com
Mon Feb 1 06:14:49 UTC 2021


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
391c2f4a5d SCI: Remove character test that's always true


Commit: 391c2f4a5d8e0ee35390c7d1de3358191e3387b2
    https://github.com/scummvm/scummvm/commit/391c2f4a5d8e0ee35390c7d1de3358191e3387b2
Author: sluicebox (22204938+sluicebox at users.noreply.github.com)
Date: 2021-01-31T22:14:36-08:00

Commit Message:
SCI: Remove character test that's always true

Fixes a gcc warning

Changed paths:
    engines/sci/engine/message.cpp


diff --git a/engines/sci/engine/message.cpp b/engines/sci/engine/message.cpp
index 8f0275740c..f795b4bb3b 100644
--- a/engines/sci/engine/message.cpp
+++ b/engines/sci/engine/message.cpp
@@ -446,7 +446,7 @@ bool MessageState::stringStage(Common::String &outstr, const Common::String &inS
 			return false;
 
 		// If it contains Hebrew letters, it's not a stage direction
-		if (g_sci->getLanguage() == Common::HE_ISR && (byte)inStr[i] >= 128 && (byte)inStr[i] <= 255)
+		if (g_sci->getLanguage() == Common::HE_ISR && (byte)inStr[i] >= 128)
 			return false;
 	}
 




More information about the Scummvm-git-logs mailing list