[Scummvm-git-logs] scummvm master -> 99d26579a0a27b2a5d0f91b5da14ed46071f7466

[mgerhardy]

This automated email contains information about 2 new commits which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
03d174384e GUI: pass record file name by reference
99d26579a0 BACKENDS: fixed mismatched new[] vs delete call in NullMixerManager


Commit: 03d174384e619133736222a32d7bd54713f07319
    https://github.com/scummvm/scummvm/commit/03d174384e619133736222a32d7bd54713f07319
Author: Martin Gerhardy (martin.gerhardy at gmail.com)
Date: 2021-02-20T22:37:19+01:00

Commit Message:
GUI: pass record file name by reference

Changed paths:
    gui/EventRecorder.cpp
    gui/EventRecorder.h


diff --git a/gui/EventRecorder.cpp b/gui/EventRecorder.cpp
index b31fcb9711..6f4fa88d43 100644
--- a/gui/EventRecorder.cpp
+++ b/gui/EventRecorder.cpp
@@ -259,7 +259,7 @@ Common::String EventRecorder::generateRecordFileName(const Common::String &targe
 }
 
 
-void EventRecorder::init(Common::String recordFileName, RecordMode mode) {
+void EventRecorder::init(const Common::String &recordFileName, RecordMode mode) {
 	_fakeMixerManager = new NullMixerManager();
 	_fakeMixerManager->init();
 	_fakeMixerManager->suspendAudio();
diff --git a/gui/EventRecorder.h b/gui/EventRecorder.h
index 08cf2700f9..01011931c9 100644
--- a/gui/EventRecorder.h
+++ b/gui/EventRecorder.h
@@ -77,7 +77,7 @@ public:
 		kRecorderPlaybackPause = 3	/**< kRecordetPlaybackPause, interal state when user pauses the playback */
 	};
 
-	void init(Common::String recordFileName, RecordMode mode);
+	void init(const Common::String &recordFileName, RecordMode mode);
 	void deinit();
 	bool processDelayMillis();
 	uint32 getRandomSeed(const Common::String &name);


Commit: 99d26579a0a27b2a5d0f91b5da14ed46071f7466
    https://github.com/scummvm/scummvm/commit/99d26579a0a27b2a5d0f91b5da14ed46071f7466
Author: Martin Gerhardy (martin.gerhardy at gmail.com)
Date: 2021-02-20T22:37:19+01:00

Commit Message:
BACKENDS: fixed mismatched new[] vs delete call in NullMixerManager

used in the EventRecorder

Changed paths:
    backends/mixer/null/null-mixer.cpp


diff --git a/backends/mixer/null/null-mixer.cpp b/backends/mixer/null/null-mixer.cpp
index 303a8110f3..821ff7d678 100644
--- a/backends/mixer/null/null-mixer.cpp
+++ b/backends/mixer/null/null-mixer.cpp
@@ -33,7 +33,7 @@ NullMixerManager::NullMixerManager() : MixerManager() {
 }
 
 NullMixerManager::~NullMixerManager() {
-	delete _samplesBuf;
+	delete[] _samplesBuf;
 }
 
 void NullMixerManager::init() {