[Scummvm-git-logs] scummvm master -> a5d0077fa2b7abcf7d218897e513cad946d3a256

bluegr bluegr at gmail.com
Mon Jan 11 21:17:01 UTC 2021


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
a5d0077fa2 SCI: Hebrew in parentheses isn't stage direction


Commit: a5d0077fa2b7abcf7d218897e513cad946d3a256
    https://github.com/scummvm/scummvm/commit/a5d0077fa2b7abcf7d218897e513cad946d3a256
Author: Zvika Haramaty (haramaty.zvika at gmail.com)
Date: 2021-01-11T23:16:56+02:00

Commit Message:
SCI: Hebrew in parentheses isn't stage direction

Changed paths:
    engines/sci/engine/message.cpp


diff --git a/engines/sci/engine/message.cpp b/engines/sci/engine/message.cpp
index 13a0d5aa18..8f0275740c 100644
--- a/engines/sci/engine/message.cpp
+++ b/engines/sci/engine/message.cpp
@@ -444,6 +444,10 @@ bool MessageState::stringStage(Common::String &outstr, const Common::String &inS
 		// SCI32 seems to support having digits in stage directions
 		if (((inStr[i] >= 'a') && (inStr[i] <= 'z')) || ((inStr[i] >= '0') && (inStr[i] <= '9') && (getSciVersion() < SCI_VERSION_2)))
 			return false;
+
+		// If it contains Hebrew letters, it's not a stage direction
+		if (g_sci->getLanguage() == Common::HE_ISR && (byte)inStr[i] >= 128 && (byte)inStr[i] <= 255)
+			return false;
 	}
 
 	// We ran into the end of the string without finding a closing bracket




More information about the Scummvm-git-logs mailing list