[Scummvm-git-logs] scummvm master -> 824bbc26d05c1e800ba92a554ca0801102d70cef

mduggan mgithub at guarana.org
Sun Jul 11 23:55:14 UTC 2021


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
824bbc26d0 ULTIMA8: Fix some uninitialized members from Coverity


Commit: 824bbc26d05c1e800ba92a554ca0801102d70cef
    https://github.com/scummvm/scummvm/commit/824bbc26d05c1e800ba92a554ca0801102d70cef
Author: Matthew Duggan (mgithub at guarana.org)
Date: 2021-07-12T08:51:10+09:00

Commit Message:
ULTIMA8: Fix some uninitialized members from Coverity

Changed paths:
    engines/ultima/ultima8/games/game_info.cpp
    engines/ultima/ultima8/gumps/movie_gump.cpp


diff --git a/engines/ultima/ultima8/games/game_info.cpp b/engines/ultima/ultima8/games/game_info.cpp
index 8ea32a6c92..009d57f932 100644
--- a/engines/ultima/ultima8/games/game_info.cpp
+++ b/engines/ultima/ultima8/games/game_info.cpp
@@ -60,7 +60,8 @@ static const GameLangDesc gamelangs[] = {
 };
 
 
-GameInfo::GameInfo() : _type(GAME_UNKNOWN), version(0), _language(GAMELANG_UNKNOWN) {
+GameInfo::GameInfo() : _type(GAME_UNKNOWN), version(0), _language(GAMELANG_UNKNOWN),
+		_ucOffVariant(GAME_UC_DEFAULT) {
 	for (int i = 0; i < 16; ++i)
 		_md5[i] = 0;
 }
diff --git a/engines/ultima/ultima8/gumps/movie_gump.cpp b/engines/ultima/ultima8/gumps/movie_gump.cpp
index 558f7807ce..556745be6d 100644
--- a/engines/ultima/ultima8/gumps/movie_gump.cpp
+++ b/engines/ultima/ultima8/gumps/movie_gump.cpp
@@ -101,7 +101,7 @@ static Common::SeekableReadStream *_tryLoadCruSubtitle(const Std::string &filena
 
 DEFINE_RUNTIME_CLASSTYPE_CODE(MovieGump)
 
-MovieGump::MovieGump() : ModalGump(), _player(nullptr), _subtitleWidget(0) {
+MovieGump::MovieGump() : ModalGump(), _player(nullptr), _subtitleWidget(0), _lastFrameNo(-1) {
 
 }
 




More information about the Scummvm-git-logs mailing list