[Scummvm-git-logs] scummvm master -> 2901700b5aeeb67dbf346325bf10d15270f4d7bc

ysj1173886760 42030331+ysj1173886760 at users.noreply.github.com
Fri Jul 23 11:04:48 UTC 2021


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
2901700b5a DIRECTOR: comment out the procedure of applying ghost ink effect to text sprite.


Commit: 2901700b5aeeb67dbf346325bf10d15270f4d7bc
    https://github.com/scummvm/scummvm/commit/2901700b5aeeb67dbf346325bf10d15270f4d7bc
Author: ysj1173886760 (1173886760 at qq.com)
Date: 2021-07-23T19:04:11+08:00

Commit Message:
DIRECTOR: comment out the procedure of applying ghost ink effect to text sprite.
it's wrong now.

Changed paths:
    engines/director/window.cpp


diff --git a/engines/director/window.cpp b/engines/director/window.cpp
index f1322c8483..84c0ffd5e9 100644
--- a/engines/director/window.cpp
+++ b/engines/director/window.cpp
@@ -343,9 +343,11 @@ int Window::preprocessColor(DirectorPlotData *p, uint32 src) {
 		case kInkTypeNotReverse:
 			src = (src == p->backColor ? p->colorWhite : 0);
 			break;
-		case kInkTypeGhost:
-			src = (src == p->foreColor ? p->backColor : p->colorWhite);
-			break;
+			// looks like this part is wrong, maybe it's very same as reverse?
+			// check warlock/DATA/WARLOCKSHIP/ENG/ABOUT to see more detail.
+//		case kInkTypeGhost:
+//			src = (src == p->foreColor ? p->backColor : p->colorWhite);
+//			break;
 		case kInkTypeNotGhost:
 			src = (src == p->backColor ? p->colorWhite : p->backColor);
 			break;




More information about the Scummvm-git-logs mailing list