[Scummvm-git-logs] scummvm master -> 6ba16f7b40fcb6f01dff3e70a12a5a077b06facc

moralrecordings code at moral.net.au
Fri Jul 23 15:56:11 UTC 2021


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
6ba16f7b40 DIRECTOR: Fix sound playFile behaviour


Commit: 6ba16f7b40fcb6f01dff3e70a12a5a077b06facc
    https://github.com/scummvm/scummvm/commit/6ba16f7b40fcb6f01dff3e70a12a5a077b06facc
Author: Scott Percival (code at moral.net.au)
Date: 2021-07-23T23:48:34+08:00

Commit Message:
DIRECTOR: Fix sound playFile behaviour

A call to AudioFileDecoder::getAudioStream() was missed during the
refactor in 682d2dbb6c998c03719ee4615bc9bddd577277b8, meaning that any
sound invoked by "sound playFile" would loop.

Fixes the narration text in Chop Suey (e.g. TABLE.DIR) from looping and
being unable to progress.

Changed paths:
    engines/director/sound.cpp


diff --git a/engines/director/sound.cpp b/engines/director/sound.cpp
index 2f0ab2049e..1727b85220 100644
--- a/engines/director/sound.cpp
+++ b/engines/director/sound.cpp
@@ -74,7 +74,7 @@ void DirectorSound::playFile(Common::String filename, uint8 soundChannel) {
 		return;
 
 	AudioFileDecoder af(filename);
-	Audio::AudioStream *sound = af.getAudioStream(DisposeAfterUse::YES);
+	Audio::AudioStream *sound = af.getAudioStream(false, DisposeAfterUse::YES);
 
 	cancelFade(soundChannel);
 	_mixer->playStream(Audio::Mixer::kSFXSoundType, &_channels[soundChannel - 1].handle, sound, -1, getChannelVolume(soundChannel));




More information about the Scummvm-git-logs mailing list