[Scummvm-git-logs] scummvm master -> ae5277f942abf851d3b0473acd2029cc6c5721f8

[antoniou79]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
ae5277f942 GUI: Update domain name for backendOptions upon renaming Game id


Commit: ae5277f942abf851d3b0473acd2029cc6c5721f8
    https://github.com/scummvm/scummvm/commit/ae5277f942abf851d3b0473acd2029cc6c5721f8
Author: antoniou79 (a.antoniou79 at gmail.com)
Date: 2021-06-20T22:50:12+03:00

Commit Message:
GUI: Update domain name for backendOptions upon renaming Game id

Without this, the ports using backendOptions Widget could error trying to access the domain with the old name

For example, the Android port, upon editing and renaming the Game Id, would error with a message like "E/ScummVM: ConfigManager::removeKey(onscreen_control, bladerunner-final-win) called on non-existent domain". This is because in its AndroidOptionsWidget::save() method (called within OptionsDialog::apply()), there were calls to removeKey() which internally was using the stale/old _domain (domain name before the renaming)

Changed paths:
    gui/editgamedialog.cpp


diff --git a/gui/editgamedialog.cpp b/gui/editgamedialog.cpp
index 319cf17a4b..304a701c10 100644
--- a/gui/editgamedialog.cpp
+++ b/gui/editgamedialog.cpp
@@ -651,6 +651,9 @@ void EditGameDialog::handleCommand(CommandSender *sender, uint32 cmd, uint32 dat
 			if (_engineOptions) {
 				_engineOptions->setDomain(newDomain);
 			}
+			if (_backendOptions) {
+				_backendOptions->setDomain(newDomain);
+			}
 		}
 	}
 	// fall through