[Scummvm-git-logs] scummvm master -> 2553e85210bf8bd06a2882e5ba1bd0cb1ff71126

criezy criezy at scummvm.org
Fri Mar 5 16:35:21 UTC 2021


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
2553e85210 KYRA: Fix error when checking is subtitles setting is set


Commit: 2553e85210bf8bd06a2882e5ba1bd0cb1ff71126
    https://github.com/scummvm/scummvm/commit/2553e85210bf8bd06a2882e5ba1bd0cb1ff71126
Author: Thierry Crozat (criezy at scummvm.org)
Date: 2021-03-05T16:34:01Z

Commit Message:
KYRA: Fix error when checking is subtitles setting is set

This should hopefully fix bug #12287

Changed paths:
    engines/kyra/engine/kyra_v1.cpp


diff --git a/engines/kyra/engine/kyra_v1.cpp b/engines/kyra/engine/kyra_v1.cpp
index 6c01778ef1..aee24a7f6e 100644
--- a/engines/kyra/engine/kyra_v1.cpp
+++ b/engines/kyra/engine/kyra_v1.cpp
@@ -566,7 +566,7 @@ void KyraEngine_v1::registerDefaultSettings() {
 		// the global subtitles settings, we're using this hack to enable subtitles
 		// for fan translations
 		const Common::ConfigManager::Domain *cur = ConfMan.getActiveDomain();
-		if (!cur || (cur && cur->getVal("subtitles").empty()))
+		if (!cur || (cur && !cur->contains("subtitles")))
 			ConfMan.setBool("subtitles", true);
 	}
 }




More information about the Scummvm-git-logs mailing list