[Scummvm-git-logs] scummvm master -> d91b87acbfa0e14e7bc70aecc59f857bd3d91d5b

digitall 547637+digitall at users.noreply.github.com
Sat Mar 13 12:35:37 UTC 2021


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
d91b87acbf COMMON: Fix GCC Warning for Implicit Copy Operator in Queue Class


Commit: d91b87acbfa0e14e7bc70aecc59f857bd3d91d5b
    https://github.com/scummvm/scummvm/commit/d91b87acbfa0e14e7bc70aecc59f857bd3d91d5b
Author: D G Turner (digitall at scummvm.org)
Date: 2021-03-13T12:34:19Z

Commit Message:
COMMON: Fix GCC Warning for Implicit Copy Operator in Queue Class

This is emitted when -Wdeprecated-copy is enabled. The fix implemented
is to explicitly declare this to be the default copy operator.

Since this may be a latent bug, this is marked with a FIXME.

Changed paths:
    common/queue.h


diff --git a/common/queue.h b/common/queue.h
index ed5f964f1b..d4ab2e05c8 100644
--- a/common/queue.h
+++ b/common/queue.h
@@ -47,6 +47,7 @@ class Queue {
 public:
 	Queue<T>() : _impl() {}
 	Queue<T>(const Queue<T> &queue) : _impl(queue._impl) {}
+	Queue<T> &operator=(const Queue<T> &other) = default; // FIXME: This may need replacing with custom copy operator code
 
 	bool empty() const {
 		return _impl.empty();




More information about the Scummvm-git-logs mailing list