[Scummvm-git-logs] scummvm master -> 2ac5fd5c02c96a33eee59359cb588d6e50811b09

[sluicebox]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
2ac5fd5c02 GUI: Fix crash when enabling auto save


Commit: 2ac5fd5c02c96a33eee59359cb588d6e50811b09
    https://github.com/scummvm/scummvm/commit/2ac5fd5c02c96a33eee59359cb588d6e50811b09
Author: sluicebox (22204938+sluicebox at users.noreply.github.com)
Date: 2021-11-11T15:30:16-06:00

Commit Message:
GUI: Fix crash when enabling auto save

"engineid" isn't present on all games. Games that predate the "engineid"
feature and haven't been run since it was introduced don't have it yet.

Fixes bug #13038

Changed paths:
    gui/options.cpp


diff --git a/gui/options.cpp b/gui/options.cpp
index 05ecd33d96..78b1c93420 100644
--- a/gui/options.cpp
+++ b/gui/options.cpp
@@ -2545,7 +2545,9 @@ bool GlobalOptionsDialog::updateAutosavePeriod(int newValue) {
 	for (ConfigManager::DomainMap::const_iterator it = domains.begin(), end = domains.end(); it != end; ++it) {
 		const Common::String target = it->_key;
 		const ConfigManager::Domain domain = it->_value;
-		const Common::String engine = domain["engineid"];
+		// note that engineid isn't present on games that predate it
+		// and haven't been run since it was introduced.
+		const Common::String engine = domain.getValOrDefault("engineid");
 		if (const Plugin *detectionPlugin = EngineMan.findPlugin(engine)) {
 			if (const Plugin *plugin = PluginMan.getEngineFromMetaEngine(detectionPlugin)) {
 				MetaEngine &metaEngine = plugin->get<MetaEngine>();