[Scummvm-git-logs] scummvm master -> ea386eda87e52315c7d38088fa77df78ed810115

athrxx athrxx at scummvm.org
Thu Oct 14 13:42:46 UTC 2021


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
ea386eda87 KYRA: (LOL) - fix sound index read on BE platforms (bug no. 12987)


Commit: ea386eda87e52315c7d38088fa77df78ed810115
    https://github.com/scummvm/scummvm/commit/ea386eda87e52315c7d38088fa77df78ed810115
Author: athrxx (athrxx at scummvm.org)
Date: 2021-10-14T15:40:30+02:00

Commit Message:
KYRA: (LOL) - fix sound index read on BE platforms (bug no. 12987)

regression from 3ae1d92f

Changed paths:
    engines/kyra/script/script_lol.cpp


diff --git a/engines/kyra/script/script_lol.cpp b/engines/kyra/script/script_lol.cpp
index 6358dff34c..15c8c365e4 100644
--- a/engines/kyra/script/script_lol.cpp
+++ b/engines/kyra/script/script_lol.cpp
@@ -1839,10 +1839,11 @@ int LoLEngine::olol_assignCustomSfx(EMCState *script) {
 	if (!c || i > 250)
 		return 0;
 
-	uint16 t = READ_LE_UINT16(&_ingameSoundIndex[i << 1]);
+	uint16 t = _ingameSoundIndex[i << 1];
 	if (t == 0xFFFF)
 		return 0;
 
+	assert(t < _ingameSoundListSize);
 	_ingameSoundList[t] = c;
 
 	return 0;




More information about the Scummvm-git-logs mailing list