[Scummvm-git-logs] scummvm master -> 76d0d4ea330c9a27b089a157ea19949935824658

moralrecordings code at moral.net.au
Fri Sep 24 18:48:59 UTC 2021


This automated email contains information about 2 new commits which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
fc23e55842 DIRECTOR: LINGO: Fix typo in month name list
76d0d4ea33 DIRECTOR: Add stronger warning for unsupported cast members


Commit: fc23e558428b37f0b568ea835bc4b8e84834affb
    https://github.com/scummvm/scummvm/commit/fc23e558428b37f0b568ea835bc4b8e84834affb
Author: Scott Percival (code at moral.net.au)
Date: 2021-09-25T02:42:05+08:00

Commit Message:
DIRECTOR: LINGO: Fix typo in month name list

Changed paths:
    engines/director/lingo/lingo-the.cpp


diff --git a/engines/director/lingo/lingo-the.cpp b/engines/director/lingo/lingo-the.cpp
index 582acd2c21..ffab25d129 100644
--- a/engines/director/lingo/lingo-the.cpp
+++ b/engines/director/lingo/lingo-the.cpp
@@ -1946,7 +1946,7 @@ void Lingo::setObjectProp(Datum &obj, Common::String &propName, Datum &val) {
 
 static const char *mfull[] = {
 	"January", "February", "March", "April", "May", "June",
-	"July", "August" "September", "October", "November", "December"
+	"July", "August", "September", "October", "November", "December"
 };
 
 static const char *wday[] = {


Commit: 76d0d4ea330c9a27b089a157ea19949935824658
    https://github.com/scummvm/scummvm/commit/76d0d4ea330c9a27b089a157ea19949935824658
Author: Scott Percival (code at moral.net.au)
Date: 2021-09-25T02:48:06+08:00

Commit Message:
DIRECTOR: Add stronger warning for unsupported cast members

Changed paths:
    engines/director/cast.cpp


diff --git a/engines/director/cast.cpp b/engines/director/cast.cpp
index 7788754ec9..1b9273f866 100644
--- a/engines/director/cast.cpp
+++ b/engines/director/cast.cpp
@@ -925,7 +925,7 @@ void Cast::loadCastData(Common::SeekableReadStreamEndian &stream, uint16 id, Res
 		_loadedCast->setVal(id, new DigitalVideoCastMember(this, id, castStream, _version));
 		break;
 	case kCastFilmLoop:
-		warning("STUB: Cast::loadCastData(): kCastFilmLoop (%d children)", res->children.size());
+		warning("STUB: Cast::loadCastData(): kCastFilmLoop (id=%d, %d children)! This will be missing from the movie and may cause problems", id, res->children.size());
 		castInfoSize = 0;
 		break;
 	case kCastPalette:
@@ -933,15 +933,15 @@ void Cast::loadCastData(Common::SeekableReadStreamEndian &stream, uint16 id, Res
 		_loadedCast->setVal(id, new PaletteCastMember(this, id, castStream, _version));
 		break;
 	case kCastPicture:
-		warning("BUILDBOT: STUB: Cast::loadCastData(): kCastPicture (%d children)", res->children.size());
+		warning("BUILDBOT: STUB: Cast::loadCastData(): kCastPicture (id=%d, %d children)! This will be missing from the movie and may cause problems", id, res->children.size());
 		castInfoSize = 0;
 		break;
 	case kCastMovie:
-		warning("STUB: Cast::loadCastData(): kCastMovie (%d children)", res->children.size());
+		warning("STUB: Cast::loadCastData(): kCastMovie (id=%d, %d children)! This will be missing from the movie and may cause problems", id, res->children.size());
 		castInfoSize = 0;
 		break;
 	default:
-		warning("Cast::loadCastData(): Unhandled cast type: %d [%s] (%d children)", castType, tag2str(castType), res->children.size());
+		warning("Cast::loadCastData(): Unhandled cast type: %d [%s] (id=%d, %d children)! This will be missing from the movie and may cause problems", castType, tag2str(castType), id, res->children.size());
 		// also don't try and read the strings... we don't know what this item is.
 		castInfoSize = 0;
 		break;




More information about the Scummvm-git-logs mailing list