[Scummvm-git-logs] scummvm master -> f92492f4a114c6b2eeabc4fc7d34be99e20401f9

rvanlaar noreply at scummvm.org
Sat Aug 27 21:41:00 UTC 2022


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
f92492f4a1 Revert "DIRECTOR: Check for cast children in buildbot"


Commit: f92492f4a114c6b2eeabc4fc7d34be99e20401f9
    https://github.com/scummvm/scummvm/commit/f92492f4a114c6b2eeabc4fc7d34be99e20401f9
Author: Roland van Laar (roland at rolandvanlaar.nl)
Date: 2022-08-27T23:40:00+02:00

Commit Message:
Revert "DIRECTOR: Check for cast children in buildbot"

Cast::loadCastChildren() iterates over all casts, not just the ones that
have children. The original commit gave a buildbot error for all casts
that weren't handled by loadCastChildren.

This reverts commit ec5e0cf1b695d6a9f9b3a643a7a88020d4cd6b64.

Changed paths:
    engines/director/cast.cpp


diff --git a/engines/director/cast.cpp b/engines/director/cast.cpp
index c55df070447..353c653c31c 100644
--- a/engines/director/cast.cpp
+++ b/engines/director/cast.cpp
@@ -684,10 +684,8 @@ void Cast::loadCastChildren() {
 			continue;
 		}
 
-		if (c->_value->_type != kCastBitmap) {
-			warning("BUILDBOT: STUB: Cast::loadCastChildren(): Unhandled child of type: %d", c->_value->_type);
+		if (c->_value->_type != kCastBitmap)
 			continue;
-		}	
 
 		// Then handle bitmaps
 		BitmapCastMember *bitmapCast = (BitmapCastMember *)c->_value;




More information about the Scummvm-git-logs mailing list