[Scummvm-git-logs] scummvm master -> 0c5aba0394fae5410b63c7892dceb1d3d33e9b60

phcoder noreply at scummvm.org
Mon Dec 12 06:16:44 UTC 2022


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
0c5aba0394 PLUMBERS: Add missing initialization of few fields


Commit: 0c5aba0394fae5410b63c7892dceb1d3d33e9b60
    https://github.com/scummvm/scummvm/commit/0c5aba0394fae5410b63c7892dceb1d3d33e9b60
Author: Vladimir Serbinenko (phcoder at gmail.com)
Date: 2022-12-12T07:16:34+01:00

Commit Message:
PLUMBERS: Add missing initialization of few fields

Namely _compositeSurface, _videoDecoder and _ctrlHelpImage

Missing init causes felete of random pointer and a crash when running
windows version of Plumbers.

Changed paths:
    engines/plumbers/plumbers.cpp


diff --git a/engines/plumbers/plumbers.cpp b/engines/plumbers/plumbers.cpp
index f409ac19d93..998619752b5 100644
--- a/engines/plumbers/plumbers.cpp
+++ b/engines/plumbers/plumbers.cpp
@@ -70,7 +70,8 @@ static const Common::JoystickButton cheatJoy[] = {
 };
 
 PlumbersGame::PlumbersGame(OSystem *syst, const ADGameDescription *gameDesc) :
-		Engine(syst), _gameDescription(gameDesc), _console(nullptr), _image(nullptr) {
+		Engine(syst), _gameDescription(gameDesc), _console(nullptr), _image(nullptr),
+		_compositeSurface(nullptr), _videoDecoder(nullptr), _ctrlHelpImage(nullptr) {
 	_timerInstalled = false;
 	_showScoreFl = false;
 	_setDurationFl = false;




More information about the Scummvm-git-logs mailing list