[Scummvm-git-logs] scummvm master -> 49a45938c1bf86d8c8d45b23404fdecc0ceb1250

[tag2015]

This automated email contains information about 3 new commits which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
64397a12b5 SKY: Properly uppercase in extra field
ae51a10e06 SKY: Set DOS as plaform for detected entries
49a45938c1 SKY: Add filesizes for most versions


Commit: 64397a12b58b927d483839ddc509a3437b136525
    https://github.com/scummvm/scummvm/commit/64397a12b58b927d483839ddc509a3437b136525
Author: Walter Agazzi (walter.agazzi at protonmail.com)
Date: 2022-12-21T22:32:19+01:00

Commit Message:
SKY: Properly uppercase in extra field

floppy -> Floppy, cd -> CD, for consistency with other engines

Changed paths:
    engines/sky/detection.cpp


diff --git a/engines/sky/detection.cpp b/engines/sky/detection.cpp
index 390019b4807..af692870556 100644
--- a/engines/sky/detection.cpp
+++ b/engines/sky/detection.cpp
@@ -41,16 +41,16 @@ struct SkyVersion {
 
 // TODO: Would be nice if Disk::determineGameVersion() used this table, too.
 static const SkyVersion skyVersions[] = {
-	{  232, -1, "floppy demo", 272, GUIO1(GUIO_NOSPEECH) }, // German
-	{  243, -1, "pc gamer demo", 109, GUIO1(GUIO_NOSPEECH) },
-	{  247, -1, "floppy demo", 267, GUIO1(GUIO_NOSPEECH) }, // English
-	{ 1404, -1, "floppy", 288, GUIO1(GUIO_NOSPEECH) },
-	{ 1413, -1, "floppy", 303, GUIO1(GUIO_NOSPEECH) },
-	{ 1445, 8830435, "floppy", 348, GUIO1(GUIO_NOSPEECH) },
-	{ 1445, -1, "floppy", 331, GUIO1(GUIO_NOSPEECH) },
-	{ 1711, -1, "cd demo", 365, GUIO0() },
-	{ 5099, -1, "cd", 368, GUIO0() },
-	{ 5097, -1, "cd", 372, GUIO0() },
+	{  232, -1, "Floppy Demo", 272, GUIO1(GUIO_NOSPEECH) }, // German
+	{  243, -1, "PC Gamer Demo", 109, GUIO1(GUIO_NOSPEECH) },
+	{  247, -1, "Floppy Demo", 267, GUIO1(GUIO_NOSPEECH) }, // English
+	{ 1404, -1, "Floppy", 288, GUIO1(GUIO_NOSPEECH) },
+	{ 1413, -1, "Floppy", 303, GUIO1(GUIO_NOSPEECH) },
+	{ 1445, 8830435, "Floppy", 348, GUIO1(GUIO_NOSPEECH) },
+	{ 1445, -1, "Floppy", 331, GUIO1(GUIO_NOSPEECH) },
+	{ 1711, -1, "CD Demo", 365, GUIO0() },
+	{ 5099, -1, "CD", 368, GUIO0() },
+	{ 5097, -1, "CD", 372, GUIO0() },
 	{ 0, 0, 0, 0, 0 }
 };
 


Commit: ae51a10e066089464b716ef76aa09096409a184f
    https://github.com/scummvm/scummvm/commit/ae51a10e066089464b716ef76aa09096409a184f
Author: Walter Agazzi (walter.agazzi at protonmail.com)
Date: 2022-12-21T22:32:19+01:00

Commit Message:
SKY: Set DOS as plaform for detected entries

Other versions (Amiga/CD32) aren't detected at all

Changed paths:
    engines/sky/detection.cpp


diff --git a/engines/sky/detection.cpp b/engines/sky/detection.cpp
index af692870556..35b23af1776 100644
--- a/engines/sky/detection.cpp
+++ b/engines/sky/detection.cpp
@@ -136,7 +136,7 @@ DetectedGames SkyMetaEngineDetection::detectGames(const Common::FSList &fslist,
 		if (sv->dinnerTableEntries) {
 			Common::String extra = Common::String::format("v0.0%d %s", sv->version, sv->extraDesc);
 
-			DetectedGame game = DetectedGame(getName(), skySetting.gameId, skySetting.description, Common::UNK_LANG, Common::kPlatformUnknown, extra);
+			DetectedGame game = DetectedGame(getName(), skySetting.gameId, skySetting.description, Common::UNK_LANG, Common::kPlatformDOS, extra);
 			game.setGUIOptions(sv->guioptions);
 
 			detectedGames.push_back(game);


Commit: 49a45938c1bf86d8c8d45b23404fdecc0ceb1250
    https://github.com/scummvm/scummvm/commit/49a45938c1bf86d8c8d45b23404fdecc0ceb1250
Author: Walter Agazzi (walter.agazzi at protonmail.com)
Date: 2022-12-21T22:32:20+01:00

Commit Message:
SKY: Add filesizes for most versions

Changed paths:
    engines/sky/detection.cpp


diff --git a/engines/sky/detection.cpp b/engines/sky/detection.cpp
index 35b23af1776..fa161d24fd0 100644
--- a/engines/sky/detection.cpp
+++ b/engines/sky/detection.cpp
@@ -41,16 +41,16 @@ struct SkyVersion {
 
 // TODO: Would be nice if Disk::determineGameVersion() used this table, too.
 static const SkyVersion skyVersions[] = {
-	{  232, -1, "Floppy Demo", 272, GUIO1(GUIO_NOSPEECH) }, // German
-	{  243, -1, "PC Gamer Demo", 109, GUIO1(GUIO_NOSPEECH) },
-	{  247, -1, "Floppy Demo", 267, GUIO1(GUIO_NOSPEECH) }, // English
-	{ 1404, -1, "Floppy", 288, GUIO1(GUIO_NOSPEECH) },
-	{ 1413, -1, "Floppy", 303, GUIO1(GUIO_NOSPEECH) },
+	{  232, 734425, "Floppy Demo", 272, GUIO1(GUIO_NOSPEECH) }, // German
+	{  243, 1328979, "PC Gamer Demo", 109, GUIO1(GUIO_NOSPEECH) },
+	{  247, 814147, "Floppy Demo", 267, GUIO1(GUIO_NOSPEECH) }, // English
+	{ 1404, 8252443, "Floppy", 288, GUIO1(GUIO_NOSPEECH) },
+	{ 1413, 8387069, "Floppy", 303, GUIO1(GUIO_NOSPEECH) },
 	{ 1445, 8830435, "Floppy", 348, GUIO1(GUIO_NOSPEECH) },
-	{ 1445, -1, "Floppy", 331, GUIO1(GUIO_NOSPEECH) },
-	{ 1711, -1, "CD Demo", 365, GUIO0() },
-	{ 5099, -1, "CD", 368, GUIO0() },
-	{ 5097, -1, "CD", 372, GUIO0() },
+	{ 1445,	-1, "Floppy", 331, GUIO1(GUIO_NOSPEECH) },
+	{ 1711, 26623798, "CD Demo", 365, GUIO0() },
+	{ 5099, 72429382, "CD", 368, GUIO0() },
+	{ 5097, 72395713, "CD", 372, GUIO0() },
 	{ 0, 0, 0, 0, 0 }
 };