[Scummvm-git-logs] scummvm master -> ace94a8944ab4c0e8dcbb05909bf84b1cf022909

sev- noreply at scummvm.org
Sun Dec 25 08:59:54 UTC 2022


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
ace94a8944 HPL!: Remove Hpl1MetaEngineDetection::findGame()


Commit: ace94a8944ab4c0e8dcbb05909bf84b1cf022909
    https://github.com/scummvm/scummvm/commit/ace94a8944ab4c0e8dcbb05909bf84b1cf022909
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2022-12-25T09:59:04+01:00

Commit Message:
HPL!: Remove Hpl1MetaEngineDetection::findGame()

It was not correct and overrided everyithing with "penumbra" gameid

Changed paths:
    engines/hpl1/detection.cpp
    engines/hpl1/detection.h


diff --git a/engines/hpl1/detection.cpp b/engines/hpl1/detection.cpp
index 873bf26cac5..b1a3d7cbf73 100644
--- a/engines/hpl1/detection.cpp
+++ b/engines/hpl1/detection.cpp
@@ -47,20 +47,16 @@ Hpl1MetaEngineDetection::Hpl1MetaEngineDetection() : AdvancedMetaEngineDetection
 }
 
 DetectedGames Hpl1MetaEngineDetection::detectGames(const Common::FSList &fslist, uint32 skipADFlags, bool skipIncomplete) {
-	DetectedGames games; 
+	DetectedGames games;
 	for(auto file : fslist) {
 		if (file.getName() == "Penumbra.exe")
-			games.push_back(DetectedGame(getName(), Hpl1::GAME_NAMES[0])); 
+			games.push_back(DetectedGame(getName(), Hpl1::GAME_NAMES[0]));
 	}
-	return games; 
-} 
+	return games;
+}
 
 PlainGameList Hpl1MetaEngineDetection::getSupportedGames() const {
-	return PlainGameList(Hpl1::GAME_NAMES); 	
-} 
-
-PlainGameDescriptor Hpl1MetaEngineDetection::findGame(const char *gameid) const {
-	return Hpl1::GAME_NAMES[0]; 
+	return PlainGameList(Hpl1::GAME_NAMES);
 }
 
 REGISTER_PLUGIN_STATIC(HPL1_DETECTION, PLUGIN_TYPE_ENGINE_DETECTION, Hpl1MetaEngineDetection);
diff --git a/engines/hpl1/detection.h b/engines/hpl1/detection.h
index fcdc8aa50ff..321198395d1 100644
--- a/engines/hpl1/detection.h
+++ b/engines/hpl1/detection.h
@@ -58,8 +58,6 @@ public:
 	DetectedGames detectGames(const Common::FSList &fslist, uint32 skipADFlags, bool skipIncomplete) override;
 
 	PlainGameList getSupportedGames() const override;
-
-	PlainGameDescriptor findGame(const char *gameid) const override;
 };
 
 #endif




More information about the Scummvm-git-logs mailing list