[Scummvm-git-logs] scummvm master -> 76a56819a31670d15cc484f2ac2f8cff35988f93

[Die4Ever]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
76a56819a3 GROOVIE: removed debugging fixed savegame dialog


Commit: 76a56819a31670d15cc484f2ac2f8cff35988f93
    https://github.com/scummvm/scummvm/commit/76a56819a31670d15cc484f2ac2f8cff35988f93
Author: Die4Ever (die4ever2005 at gmail.com)
Date: 2022-01-14T04:40:51-06:00

Commit Message:
GROOVIE: removed debugging fixed savegame dialog

We don't need this dialog anymore since we know how to reproduce it. You
just need to make any move in the triangle puzzle in the chapel.

Changed paths:
    engines/groovie/script.cpp


diff --git a/engines/groovie/script.cpp b/engines/groovie/script.cpp
index ff4583e19cb..2680f934ef5 100644
--- a/engines/groovie/script.cpp
+++ b/engines/groovie/script.cpp
@@ -615,24 +615,17 @@ void Script::savegame(uint slot) {
 		return;
 	}
 
-	// HACK: intermittent bug, I think 0x0BF is supposed to be for open house mode, only in save slot 0
-	bool fixed = false;
+	// HACK: I think 0x0BF is supposed to be for open house mode, should only be in save slot 0
+	// the script for the triangle puzzle, tx.grv, sets _variables[191] == 1
 	if (slot != 0 && _variables[191] == 1 && _version == kGroovieT11H) {
-		warning("fixing variable 0x0BF");
+		warning("savegame slot %u, fixing variable 0x0BF was %u", slot, _variables[191]);
 		_variables[191] = 0;
-		fixed = true;
 	}
 
 	// Saving the variables. It is endian safe because they're byte variables
 	file->write(_variables, 0x400);
 	delete file;
 
-	// HACK: hopefully this will help us track it down
-	if (fixed) {
-		g_system->messageBox(LogMessageType::kWarning, "fixed invalid save, please share your log file with us");
-		g_system->displayLogFile();
-	}
-
 	// Cache the saved name
 	for (int i = 0; i < 15; i++) {
 		newchar = _variables[i] + 0x30;