[Scummvm-git-logs] scummvm Thunderforge-about-remove-ellipsis -> 90bb4274dde318e79e80c535a1e14e52390f8e37

[Thunderforge]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
90bb4274dd GUI: Changing "About..." button to "About"


Commit: 90bb4274dde318e79e80c535a1e14e52390f8e37
    https://github.com/scummvm/scummvm/commit/90bb4274dde318e79e80c535a1e14e52390f8e37
Author: Thunderforge (wjherrmann at gmail.com)
Date: 2022-01-25T19:22:12-06:00

Commit Message:
GUI: Changing "About..." button to "About"

The current recommended and de factor behavior from both Microsoft and Apple is to have "About" menus be without trailing ellipses. Therefore, I think we should follow suit.

Traditionally, About menus and buttons had a trailing ellipsis. [This article](https://uxdesign.cc/dot-dot-dot-7ce6170bfc7f) demonstrates this behavior for  both Mac OS 1.0 (technically "System 1.0") and Windows 1.0.

However, current versions of macOS and Windows do not have a trailing ellipsis in About menus. Moreover, their design guidelines recommend not using them. From [Apple](https://developer.apple.com/design/human-interface-guidelines/macos/menus/menu-anatomy/):

> Use an ellipsis whenever choosing a menu item requires additional input from the user. The ellipsis character (…) means a dialog or separate window will open and prompt the user for additional information or to make a choice.

Since no additional input is required from the user for the About menu, it is inappropriate to use an ellipsis according to these guidlelines.

Microsoft [explicitly says](https://docs.microsoft.com/en-us/windows/win32/uxguide/ctrl-command-buttons) that About menus should not have an ellipsis (emphasis mine):

> This doesn't mean you should use an ellipsis whenever an action displays another window only when additional information is required to perform the action. Consequently,** any command button whose implicit verb is to "show another window" doesn't take an ellipsis, such as with the commands About**, Advanced, Help (or any other command linking to a Help topic), Options, Properties, or Settings.

Given all this, I think we should be in line with current best practices and remove it from the menu.

Changed paths:
    gui/launcher.cpp


diff --git a/gui/launcher.cpp b/gui/launcher.cpp
index a49f0cabfa1..1b629f3c2e6 100644
--- a/gui/launcher.cpp
+++ b/gui/launcher.cpp
@@ -227,7 +227,7 @@ void LauncherDialog::build() {
 #endif
 	if (!g_system->hasFeature(OSystem::kFeatureNoQuit))
 		new ButtonWidget(this, _title + ".QuitButton", _("~Q~uit"), _("Quit ScummVM"), kQuitCmd);
-	new ButtonWidget(this, _title + ".AboutButton", _("A~b~out..."), _("About ScummVM"), kAboutCmd);
+	new ButtonWidget(this, _title + ".AboutButton", _("A~b~out"), _("About ScummVM"), kAboutCmd);
 	new ButtonWidget(this, _title + ".OptionsButton", _("~O~ptions..."), _("Change global ScummVM options"), kOptionsCmd);
 
 	// Above the lowest button rows: two more buttons (directly below the list box)