[Scummvm-git-logs] scummvm master -> 57ee73f33f852ee063c08990f0ad171e8210c51e

elasota noreply at scummvm.org
Mon Jul 4 03:51:53 UTC 2022


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
57ee73f33f MTROPOLIS: Fix indexed list reads not working correctly


Commit: 57ee73f33f852ee063c08990f0ad171e8210c51e
    https://github.com/scummvm/scummvm/commit/57ee73f33f852ee063c08990f0ad171e8210c51e
Author: elasota (ejlasota at gmail.com)
Date: 2022-07-03T23:51:33-04:00

Commit Message:
MTROPOLIS: Fix indexed list reads not working correctly

Changed paths:
    engines/mtropolis/miniscript.cpp


diff --git a/engines/mtropolis/miniscript.cpp b/engines/mtropolis/miniscript.cpp
index 3f5ac14616c..93c32448e4c 100644
--- a/engines/mtropolis/miniscript.cpp
+++ b/engines/mtropolis/miniscript.cpp
@@ -1533,6 +1533,11 @@ MiniscriptInstructionOutcome GetChild::readRValueAttribIndexed(MiniscriptThread
 				thread->error("Unable to list value at specified index");
 				return kMiniscriptInstructionOutcomeFailed;
 			}
+
+			if (!list->getAtIndex(realIndex, valueSrcDest)) {
+				thread->error("List read index out of bounds");
+				return kMiniscriptInstructionOutcomeFailed;
+			}
 		} else {
 			thread->error("Unable to read list attribute '" + attrib + "'");
 			return kMiniscriptInstructionOutcomeFailed;




More information about the Scummvm-git-logs mailing list