[Scummvm-git-logs] scummvm master -> 0dede3f842d684e7c337b234fe0bb71ca4bf0872

[djsrv]

This automated email contains information about 2 new commits which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
850af8683f DIRECTOR: LINGO: Add warnings for b_open Lingo function
0dede3f842 DIRECTOR: LINGO: Add messageDialog modal for open builtin command


Commit: 850af8683f88b43b2a07e9cceb5fd7e4a7f2c1b0
    https://github.com/scummvm/scummvm/commit/850af8683f88b43b2a07e9cceb5fd7e4a7f2c1b0
Author: Pragyansh Chaturvedi (pragyanshchaturvedi18 at gmail.com)
Date: 2022-07-06T22:05:03-05:00

Commit Message:
DIRECTOR: LINGO: Add warnings for b_open Lingo function

Changed paths:
    engines/director/lingo/lingo-builtins.cpp


diff --git a/engines/director/lingo/lingo-builtins.cpp b/engines/director/lingo/lingo-builtins.cpp
index 4eaa2c704c1..c08255b1c16 100644
--- a/engines/director/lingo/lingo-builtins.cpp
+++ b/engines/director/lingo/lingo-builtins.cpp
@@ -1113,9 +1113,10 @@ void LB::b_getNthFileNameInFolder(int nargs) {
 }
 
 void LB::b_open(int nargs) {
-	g_lingo->printSTUBWithArglist("b_open", nargs);
-
-	g_lingo->dropStack(nargs);
+	Datum d = g_lingo->pop();
+	if (nargs == 2)
+		g_lingo->pop();
+	warning("LB::b_open(): Unsupported command open encountered -> The movie tried to open %s", d.asString().c_str());
 }
 
 void LB::b_openDA(int nargs) {


Commit: 0dede3f842d684e7c337b234fe0bb71ca4bf0872
    https://github.com/scummvm/scummvm/commit/0dede3f842d684e7c337b234fe0bb71ca4bf0872
Author: Pragyansh Chaturvedi (pragyanshchaturvedi18 at gmail.com)
Date: 2022-07-06T22:05:03-05:00

Commit Message:
DIRECTOR: LINGO: Add messageDialog modal for open builtin command

Changed paths:
    engines/director/lingo/lingo-builtins.cpp


diff --git a/engines/director/lingo/lingo-builtins.cpp b/engines/director/lingo/lingo-builtins.cpp
index c08255b1c16..2da657aeb15 100644
--- a/engines/director/lingo/lingo-builtins.cpp
+++ b/engines/director/lingo/lingo-builtins.cpp
@@ -1117,6 +1117,13 @@ void LB::b_open(int nargs) {
 	if (nargs == 2)
 		g_lingo->pop();
 	warning("LB::b_open(): Unsupported command open encountered -> The movie tried to open %s", d.asString().c_str());
+
+	if (!debugChannelSet(-1, kDebugFewFramesOnly) &&
+		!(g_director->getGameGID() == GID_TEST || g_director->getGameGID() == GID_TESTALL)) {
+		Common::U32String message = Common::String::format("Unsupported command open encountered -> The movie tried to execute open %s!", d.asString().c_str());
+		GUI::MessageDialog dialog(message, _("Ok"));
+		dialog.runModal();
+	}
 }
 
 void LB::b_openDA(int nargs) {