[Scummvm-git-logs] scummvm master -> 414e1a9b0c2d72d26927779998dbcdd2d3579e24

[aquadran]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
414e1a9b0c GRIM: partially implemented opcode SetActorInvClipNode and added some comments.


Commit: 414e1a9b0c2d72d26927779998dbcdd2d3579e24
    https://github.com/scummvm/scummvm/commit/414e1a9b0c2d72d26927779998dbcdd2d3579e24
Author: Paweł Kołodziejski (aquadran at gmail.com)
Date: 2022-06-07T22:59:16+02:00

Commit Message:
GRIM: partially implemented opcode SetActorInvClipNode and added some comments.

Changed paths:
    engines/grim/lua_v1_actor.cpp


diff --git a/engines/grim/lua_v1_actor.cpp b/engines/grim/lua_v1_actor.cpp
index bdaf933053f..3412517d772 100644
--- a/engines/grim/lua_v1_actor.cpp
+++ b/engines/grim/lua_v1_actor.cpp
@@ -1541,7 +1541,27 @@ void Lua_V1::GetActorRect() {
 }
 
 void Lua_V1::SetActorInvClipNode() {
-	warning("Stub function: SetActorInvClipNode");
+	lua_Object actorObj = lua_getparam(1);
+	lua_Object nodeObj = lua_getparam(2);
+
+	if (!lua_isuserdata(actorObj) || actorObj == LUA_NOOBJECT) {
+		return;
+	}
+	/*Actor *actor =*/ getactor(actorObj);
+	int nodeId = (int)lua_getnumber(nodeObj);
+
+	// Game script in grim fandango using it on animation of take in/out things from inventory.
+	// It's unknown purpose of this opcode.
+	//
+	// The node id is 13 'null18' which is between 'hand' and 'thumb'.
+	// Opcode with above node id is used on starting animation.
+	// Exception is when take out 'scythe', then node id is -1.
+	//
+	// The node id -1 is when animation finished.
+	//
+	// There is no known visual differences between lack implementation and original.
+	// Possible it's original implemenation specific or left over from development phase.
+	debug(2, "Stub function: SetActorInvClipNode(%d)", nodeId);
 }
 
 void Lua_V1::SetActorClipPlane() {