[Scummvm-git-logs] scummvm master -> 410ae706c409538d784862cebd959f1f8ee65027
digitall
noreply at scummvm.org
Wed Jun 22 16:12:23 UTC 2022
This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .
Summary:
410ae706c4 MTROPOLIS: Fix Accessible Non-Virtual Destructor GCC Warnings
Commit: 410ae706c409538d784862cebd959f1f8ee65027
https://github.com/scummvm/scummvm/commit/410ae706c409538d784862cebd959f1f8ee65027
Author: D G Turner (digitall at scummvm.org)
Date: 2022-06-22T17:09:22+01:00
Commit Message:
MTROPOLIS: Fix Accessible Non-Virtual Destructor GCC Warnings
These are emitted when the base class has virtual functions with a
non-virtual destructor (including the default implicit one created
by the compiler). The warning is enabled when -Wnon-virtual-dtor is
passed to the GCC compiler.
Changed paths:
engines/mtropolis/runtime.cpp
engines/mtropolis/runtime.h
diff --git a/engines/mtropolis/runtime.cpp b/engines/mtropolis/runtime.cpp
index 7d88a485109..fb88575579d 100644
--- a/engines/mtropolis/runtime.cpp
+++ b/engines/mtropolis/runtime.cpp
@@ -340,6 +340,9 @@ ColorRGB8 ColorRGB8::create(uint8 r, uint8 g, uint8 b) {
MessageFlags::MessageFlags() : relay(true), cascade(true), immediate(true) {
}
+IDynamicValueWriteInterface::~IDynamicValueWriteInterface() {
+}
+
Common::Point Point16POD::toScummVMPoint() const {
return Common::Point(x, y);
}
diff --git a/engines/mtropolis/runtime.h b/engines/mtropolis/runtime.h
index 6df6b561b08..15a69509abc 100644
--- a/engines/mtropolis/runtime.h
+++ b/engines/mtropolis/runtime.h
@@ -450,6 +450,7 @@ struct DynamicValue;
struct DynamicList;
struct IDynamicValueWriteInterface {
+ virtual ~IDynamicValueWriteInterface();
virtual MiniscriptInstructionOutcome write(MiniscriptThread *thread, const DynamicValue &dest, void *objectRef, uintptr ptrOrOffset) const = 0;
virtual MiniscriptInstructionOutcome refAttrib(MiniscriptThread *thread, DynamicValueWriteProxy &proxy, void *objectRef, uintptr ptrOrOffset, const Common::String &attrib) const = 0;
virtual MiniscriptInstructionOutcome refAttribIndexed(MiniscriptThread *thread, DynamicValueWriteProxy &proxy, void *objectRef, uintptr ptrOrOffset, const Common::String &attrib, const DynamicValue &index) const = 0;
More information about the Scummvm-git-logs
mailing list