[Scummvm-git-logs] scummvm master -> 9f900fac321ec0c27162c25aac436c8d7cd64fc9

[digitall]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
9f900fac32 GLK: HUGO: Fix Duplicated Branch GCC Compiler Warning


Commit: 9f900fac321ec0c27162c25aac436c8d7cd64fc9
    https://github.com/scummvm/scummvm/commit/9f900fac321ec0c27162c25aac436c8d7cd64fc9
Author: D G Turner (digitall at scummvm.org)
Date: 2022-03-25T21:11:33Z

Commit Message:
GLK: HUGO: Fix Duplicated Branch GCC Compiler Warning

This is emitted if -Wduplicated-branches is passed.

Changed paths:
    engines/glk/hugo/herun.cpp


diff --git a/engines/glk/hugo/herun.cpp b/engines/glk/hugo/herun.cpp
index 89902f3104f..31eaac68ea1 100644
--- a/engines/glk/hugo/herun.cpp
+++ b/engines/glk/hugo/herun.cpp
@@ -1037,9 +1037,14 @@ void Hugo::RunPrint() {
 				{
 					if (!hexnumber)
 					{
+						// FIXME: This code has identical branch code since the cast to unsigned int of a
+						//        is reversed by passing this to itoa as this has the function signature of:
+						//        char * itoa(int value, char *str, int base)
+#if 0
 						if (capital)
 							itoa((unsigned int)a, line, 10);
 						else
+#endif
 							itoa(a, line, 10);
 						capital = 0;
 					}