[Scummvm-git-logs] scummvm master -> 98552a75d32bbf0339457427f747df51bd3bb559

dwatteau noreply at scummvm.org
Sun Oct 2 19:09:35 UTC 2022


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
98552a75d3 SCUMM: JANITORIAL: Better description of the French MI1 release with buggy MT-32


Commit: 98552a75d32bbf0339457427f747df51bd3bb559
    https://github.com/scummvm/scummvm/commit/98552a75d32bbf0339457427f747df51bd3bb559
Author: Donovan Watteau (contrib at dwatteau.fr)
Date: 2022-10-02T21:08:05+02:00

Commit Message:
SCUMM: JANITORIAL: Better description of the French MI1 release with buggy MT-32

I'm told by some French players that only the 8-disk French VGA floppy
release had invalid MT-32 content, but that the 4-disk release didn't
have this problem. The MD5 check still appears to be OK, but the comment
was a bit wrong.

Changed paths:
    engines/scumm/scumm.cpp


diff --git a/engines/scumm/scumm.cpp b/engines/scumm/scumm.cpp
index 85dc936d714..34dd82ea92c 100644
--- a/engines/scumm/scumm.cpp
+++ b/engines/scumm/scumm.cpp
@@ -1921,10 +1921,11 @@ void ScummEngine::setupMusic(int midi, const Common::String &macInstrumentFile)
 		}
 	}
 
-	// WORKAROUND: MT-32 support is broken in the French VGA floppy version
-	// of MI1 (the index references an invalid DISK00.LEC file, and the
+	// WORKAROUND: MT-32 support is broken in the 8-disk French VGA floppy
+	// version of MI1 (the index references an invalid DISK00.LEC file, and the
 	// 'roland' room appears to be completely missing). We can't do much about
-	// this; revert to Adlib so that users don't get confused by the error.
+	// this; revert to Adlib so that users don't get confused by the fatal
+	// error about DISK00.LEC.
 	if (_game.id == GID_MONKEY_VGA && _language == Common::FR_FRA && _sound->_musicType == MDT_MIDI &&
 		memcmp(_gameMD5, "\xa0\x1f\xab\x4a\x64\xd4\x7b\x96\xe2\xe5\x8e\x6b\x0f\x82\x5c\xc7", 16) == 0) {
 		GUI::MessageDialog dialog(




More information about the Scummvm-git-logs mailing list