[Scummvm-git-logs] scummvm master -> 2e92852d577645ef41caf60fe227467235345b3e

[rvanlaar]

This automated email contains information about 2 new commits which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
407902599e TESTS: Fix clang++ warning
2e92852d57 TESTS: resolve clang warning


Commit: 407902599ebaaf1d040dc2752f40c840254b5927
    https://github.com/scummvm/scummvm/commit/407902599ebaaf1d040dc2752f40c840254b5927
Author: Roland van Laar (roland at rolandvanlaar.nl)
Date: 2022-10-06T19:01:15+02:00

Commit Message:
TESTS: Fix clang++ warning

./test/common/md5.h:17:3: warning: suspicious concatenation of string literals in an array initialization; did you mean to separate the elements with a comma? [-Wstring-concatenation]
                "345678901234567890"

Changed paths:
    test/common/md5.h


diff --git a/test/common/md5.h b/test/common/md5.h
index f310845bb96..1970b796bb1 100644
--- a/test/common/md5.h
+++ b/test/common/md5.h
@@ -13,8 +13,8 @@ static const char *md5_test_string[] = {
 	"message digest",
 	"abcdefghijklmnopqrstuvwxyz",
 	"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789",
-	"12345678901234567890123456789012345678901234567890123456789012" \
-		"345678901234567890"
+	("12345678901234567890123456789012345678901234567890123456789012"
+		"345678901234567890")
 };
 
 static const char *md5_test_digest[] = {


Commit: 2e92852d577645ef41caf60fe227467235345b3e
    https://github.com/scummvm/scummvm/commit/2e92852d577645ef41caf60fe227467235345b3e
Author: Roland van Laar (roland at rolandvanlaar.nl)
Date: 2022-10-06T19:01:15+02:00

Commit Message:
TESTS: resolve clang warning

Run tests with -Wno-self-assign-overloaded
Some tests explicitely assign the value of the variable type to itself.

Fixes warnings such as these:

./test/common/str.h:201:9: warning: explicitly assigning value of variable of type 'Common::String' to itself [-Wself-assign-overloaded]
                foo10 = foo10;
                ~~~~~ ^ ~~~~~

Changed paths:
    test/module.mk


diff --git a/test/module.mk b/test/module.mk
index becd3e82c9f..d1fc45452c2 100644
--- a/test/module.mk
+++ b/test/module.mk
@@ -44,7 +44,8 @@ endif
 TEST_FLAGS   := --runner=StdioPrinter --no-std --no-eh
 TEST_CFLAGS  := $(CFLAGS) -I$(srcdir)/test/cxxtest
 TEST_LDFLAGS := $(LDFLAGS) $(LIBS)
-TEST_CXXFLAGS := $(filter-out -Wglobal-constructors,$(CXXFLAGS))
+TEST_CXXFLAGS  := $(filter-out -Wglobal-constructors,$(CXXFLAGS))
+TEST_CXXFLAGS += -Wno-self-assign-overloaded
 
 ifdef WIN32
 TEST_LDFLAGS := $(filter-out -mwindows,$(TEST_LDFLAGS))