[Scummvm-git-logs] scummvm master -> c75641538897e6834e113b8516097713f7391084

lephilousophe noreply at scummvm.org
Mon Oct 17 20:20:32 UTC 2022


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
c756415388 BACKENDS: OPENGL: Don't fail if parameter is not present in preset


Commit: c75641538897e6834e113b8516097713f7391084
    https://github.com/scummvm/scummvm/commit/c75641538897e6834e113b8516097713f7391084
Author: Le Philousophe (lephilousophe at users.noreply.github.com)
Date: 2022-10-17T22:19:26+02:00

Commit Message:
BACKENDS: OPENGL: Don't fail if parameter is not present in preset

RetroArch doesn't use this parameters value and looks up directly for
entries so it would never fail on this.

Changed paths:
    backends/graphics/opengl/pipelines/libretro/parser.cpp


diff --git a/backends/graphics/opengl/pipelines/libretro/parser.cpp b/backends/graphics/opengl/pipelines/libretro/parser.cpp
index e9d9b16ea0f..3e2b2a17c46 100644
--- a/backends/graphics/opengl/pipelines/libretro/parser.cpp
+++ b/backends/graphics/opengl/pipelines/libretro/parser.cpp
@@ -521,11 +521,13 @@ bool PresetParser::parseParameters() {
 	Common::StringTokenizer tokenizer(parameters, ";");
 	while (!tokenizer.empty()) {
 		Common::String key = tokenizer.nextToken();
-		float value;
-		if (!lookUpValue(key, &value)) {
-			return false;
+		if (_entries.contains(key)) {
+			float value;
+			if (!lookUpValue(key, &value)) {
+				return false;
+			}
+			_shader->parameters[key] = value;
 		}
-		_shader->parameters[key] = value;
 	}
 
 	return true;




More information about the Scummvm-git-logs mailing list