[Scummvm-git-logs] scummvm master -> 92639d8ba408cc47cebda2345c9df393acc9694f

[sluicebox]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
92639d8ba4 SCI: fix bug no. 11683 ("QFG2 - Heavy reverb from city street sounds ...")


Commit: 92639d8ba408cc47cebda2345c9df393acc9694f
    https://github.com/scummvm/scummvm/commit/92639d8ba408cc47cebda2345c9df393acc9694f
Author: athrxx (athrxx at scummvm.org)
Date: 2022-09-02T14:55:44-08:00

Commit Message:
SCI: fix bug no. 11683 ("QFG2 - Heavy reverb from city street sounds ...")

Changed paths:
    engines/sci/sound/music.cpp


diff --git a/engines/sci/sound/music.cpp b/engines/sci/sound/music.cpp
index 1ec68ae49fc..92ede40fd22 100644
--- a/engines/sci/sound/music.cpp
+++ b/engines/sci/sound/music.cpp
@@ -1323,7 +1323,10 @@ ChannelRemapping *SciMusic::determineChannelMap() {
 	if (_playList.empty())
 		return map;
 
-	// TODO: set reverb, either from first song, or from global???
+	// Set reverb, either from first song, or from global (verified with KQ5 floppy
+	// and LSL6 interpreters, fixes bug # 11683 ("QFG2 - Heavy reverb from city street sounds...").
+	int8 reverb = _playList.front()->reverb;
+	_pMidiDrv->setReverb(reverb == 127 ? _globalReverb : reverb);
 
 	MusicList::iterator songIter;
 	int songIndex = -1;