[Scummvm-git-logs] scummvm master -> 6fada68d761b9c45e5e3c283ea387b85cab8cf71

rvanlaar noreply at scummvm.org
Mon Sep 19 22:22:35 UTC 2022


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
6fada68d76 DIRECTOR: fix memory leak


Commit: 6fada68d761b9c45e5e3c283ea387b85cab8cf71
    https://github.com/scummvm/scummvm/commit/6fada68d761b9c45e5e3c283ea387b85cab8cf71
Author: Roland van Laar (roland at rolandvanlaar.nl)
Date: 2022-09-20T00:21:09+02:00

Commit Message:
DIRECTOR: fix memory leak

Delete the quicktime video object when falling back to the AVI decoder.

Changed paths:
    engines/director/castmember.cpp


diff --git a/engines/director/castmember.cpp b/engines/director/castmember.cpp
index 51708915411..5a8573c7509 100644
--- a/engines/director/castmember.cpp
+++ b/engines/director/castmember.cpp
@@ -732,6 +732,7 @@ bool DigitalVideoCastMember::loadVideo(Common::String path) {
 	debugC(2, kDebugLoading | kDebugImages, "Loading video %s -> %s", path.c_str(), path1.c_str());
 	bool result = _video->loadFile(Common::Path(path1, g_director->_dirSeparator));
 	if (!result) {
+		delete _video;
 		_video = new Video::AVIDecoder();
 		result = _video->loadFile(Common::Path(path1, g_director->_dirSeparator));
 	}




More information about the Scummvm-git-logs mailing list