[Scummvm-git-logs] scummvm master -> 477667688d4eb0d4aa61ff254c047fef017fdb7b

rvanlaar noreply at scummvm.org
Tue Sep 20 14:32:18 UTC 2022


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
477667688d DIRECTOR: Fix memory leak in Cast::loadBitmapData


Commit: 477667688d4eb0d4aa61ff254c047fef017fdb7b
    https://github.com/scummvm/scummvm/commit/477667688d4eb0d4aa61ff254c047fef017fdb7b
Author: Roland van Laar (roland at rolandvanlaar.nl)
Date: 2022-09-20T16:30:57+02:00

Commit Message:
DIRECTOR: Fix memory leak in Cast::loadBitmapData

Delete `pic` when returning early.

Changed paths:
    engines/director/cast.cpp


diff --git a/engines/director/cast.cpp b/engines/director/cast.cpp
index 1d71d89fe52..263fe46a221 100644
--- a/engines/director/cast.cpp
+++ b/engines/director/cast.cpp
@@ -721,8 +721,10 @@ void Cast::loadBitmapData(int key, BitmapCastMember *bitmapCast) {
 		break;
 	}
 
-	if (!img)
+	if (!img) {
+		delete pic;
 		return;
+	}
 
 	img->loadStream(*pic);
 




More information about the Scummvm-git-logs mailing list