[Scummvm-git-logs] scummvm master -> cbccad776106ae37a236475560430efe47367461

athrxx noreply at scummvm.org
Sun Apr 30 12:08:19 UTC 2023


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
cbccad7761 SCUMM: (LOOM) - fix volume glitch (regression)


Commit: cbccad776106ae37a236475560430efe47367461
    https://github.com/scummvm/scummvm/commit/cbccad776106ae37a236475560430efe47367461
Author: athrxx (athrxx at scummvm.org)
Date: 2023-04-30T14:04:33+02:00

Commit Message:
SCUMM: (LOOM) - fix volume glitch (regression)

Changed paths:
    engines/scumm/imuse/imuse_part.cpp


diff --git a/engines/scumm/imuse/imuse_part.cpp b/engines/scumm/imuse/imuse_part.cpp
index 9afdc21c9ba..98279820845 100644
--- a/engines/scumm/imuse/imuse_part.cpp
+++ b/engines/scumm/imuse/imuse_part.cpp
@@ -367,21 +367,16 @@ void Part::sendAll() {
 }
 
 void Part::sendPitchBend() {
-	if (!_mc)
-		return;
-
 	if (_se->_newSystem && !_pitchbend_factor) {
 		sendVolumeFade();
 		return;
 	}
 
-	_mc->pitchBend(_pitchbend);
+	if (_mc)
+		_mc->pitchBend(_pitchbend);
 }
 
 void Part::sendVolume(int8 fadeModifier) {
-	if (!_mc)
-		return;
-
 	uint16 vol = (_vol + fadeModifier + 1) * _player->getEffectiveVolume();
 
 	if (_se->_newSystem)




More information about the Scummvm-git-logs mailing list