[Scummvm-git-logs] scummvm master -> 33d4b358692a56678c4af0c059ed8d439b386c98

[sev-]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
33d4b35869 DIRECTOR: Fix visibility issue when setting window properties


Commit: 33d4b358692a56678c4af0c059ed8d439b386c98
    https://github.com/scummvm/scummvm/commit/33d4b358692a56678c4af0c059ed8d439b386c98
Author: Harishankar Kumar (hari01584 at gmail.com)
Date: 2023-08-09T18:49:16+02:00

Commit Message:
DIRECTOR: Fix visibility issue when setting window properties

This patch fixes the behaviour of windows when setting their
properties (e.g. titleVisibility, Modal, etc) from the lingo.

Initially the window was set to be visible when the property was
set, but this is not the expected behaviour. The window should
only be visible when the `open` command is called. Removed `setVisible(true)`
from various window properties assignment functions.

Fixes popupmenu overlay in `meet-mediaband` and white rectangle when
opening `mcluhan-win`.

--start-movie="main\stvimenu.dxr" mediaband-win

Changed paths:
    engines/director/window.cpp


diff --git a/engines/director/window.cpp b/engines/director/window.cpp
index 1d983a742e5..ff812a3b772 100644
--- a/engines/director/window.cpp
+++ b/engines/director/window.cpp
@@ -223,8 +223,6 @@ void Window::setStageColor(uint32 stageColor, bool forceReset) {
 void Window::setTitleVisible(bool titleVisible) {
 	MacWindow::setTitleVisible(titleVisible);
 	updateBorderType();
-
-	setVisible(true); // Activate this window on top
 }
 
 Datum Window::getStageRect() {
@@ -262,14 +260,10 @@ void Window::setModal(bool modal) {
 		_wm->setLockedWidget(this);
 		_isModal = true;
 	}
-
-	setVisible(true); // Activate this window on top
 }
 
 void Window::setFileName(Common::String filename) {
 	setNextMovie(filename);
-
-	setVisible(true); // Activate this window on top
 }
 
 void Window::reset() {