[Scummvm-git-logs] scummvm master -> a8692ebf13cba6ddda9aab5ad680ca4bbdaf814e

[lephilousophe]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
a8692ebf13 ANDROID: Make SAF strings translatable and better looking


Commit: a8692ebf13cba6ddda9aab5ad680ca4bbdaf814e
    https://github.com/scummvm/scummvm/commit/a8692ebf13cba6ddda9aab5ad680ca4bbdaf814e
Author: Le Philousophe (lephilousophe at users.noreply.github.com)
Date: 2023-02-12T17:54:45+01:00

Commit Message:
ANDROID: Make SAF strings translatable and better looking

Changed paths:
    backends/fs/android/android-saf-fs.cpp
    backends/fs/android/android-saf-fs.h
    backends/platform/android/options.cpp
    po/POTFILES


diff --git a/backends/fs/android/android-saf-fs.cpp b/backends/fs/android/android-saf-fs.cpp
index 48b2f74e20e..b905386b5b0 100644
--- a/backends/fs/android/android-saf-fs.cpp
+++ b/backends/fs/android/android-saf-fs.cpp
@@ -660,7 +660,8 @@ void AddSAFFakeNode::makeProxySAF() const {
 		return;
 	}
 
-	jobject saftree = JNI::getNewSAFTree(true, true, "", "Choose a new SAF tree");
+	// I18N: This may be displayed in the Android UI used to add a Sotrage Attach Framework authorization
+	jobject saftree = JNI::getNewSAFTree(true, true, "", _("Choose a new folder"));
 	if (!saftree) {
 		return;
 	}
diff --git a/backends/fs/android/android-saf-fs.h b/backends/fs/android/android-saf-fs.h
index bd82d6699b5..f6ff2690515 100644
--- a/backends/fs/android/android-saf-fs.h
+++ b/backends/fs/android/android-saf-fs.h
@@ -23,6 +23,8 @@
 #define ANDROID_SAF_FILESYSTEM_H
 
 #include <jni.h>
+
+#include "common/translation.h"
 #include "backends/fs/abstract-fs.h"
 
 /**
@@ -167,8 +169,9 @@ public:
 
 	bool getChildren(AbstractFSList &list, ListMode mode, bool hidden) const override;
 
-	Common::U32String getDisplayName() const override { return Common::U32String("\x01" "<Add SAF node>"); };
-	Common::String getName() const override { return "\x01" "<Add SAF node>"; };
+	// I18N: This is displayed in the file browser to let the user choose a new folder for Android Storage Attached Framework
+	Common::U32String getDisplayName() const override { return Common::U32String::format("\x01<%s>", _("Add a new folder").c_str()); };
+	Common::String getName() const override { return Common::String::format("\x01<%s>", _("Add a new folder").encode().c_str()); };
 	Common::String getPath() const override;
 
 	bool isDirectory() const override { return true; }
diff --git a/backends/platform/android/options.cpp b/backends/platform/android/options.cpp
index 24439cda053..75a03f77d4b 100644
--- a/backends/platform/android/options.cpp
+++ b/backends/platform/android/options.cpp
@@ -149,7 +149,8 @@ AndroidOptionsWidget::AndroidOptionsWidget(GuiObject *boss, const Common::String
 
 	if (inAppDomain && AndroidFilesystemFactory::instance().hasSAF()) {
 		// Only show this checkbox in Options (via Options... in the launcher), and not at game domain level (via Edit Game...)
-		(new GUI::ButtonWidget(widgetsBoss(), "AndroidOptionsDialog.ForgetSAFButton", _("Forget SAF authorization"), Common::U32String(), kRemoveCmd))->setTarget(this);
+		// I18N: This button opens a list of all folders added for Android Storage Attached Framework
+		(new GUI::ButtonWidget(widgetsBoss(), "AndroidOptionsDialog.ForgetSAFButton", _("Remove folder authorizations..."), Common::U32String(), kRemoveCmd))->setTarget(this);
 	}
 }
 
diff --git a/po/POTFILES b/po/POTFILES
index 8c5a992cbaa..e6deb0d17f5 100644
--- a/po/POTFILES
+++ b/po/POTFILES
@@ -70,6 +70,8 @@ backends/events/default/default-events.cpp
 backends/events/gph/gph-events.cpp
 backends/events/maemosdl/maemosdl-events.cpp
 backends/events/openpandora/op-events.cpp
+backends/fs/android/android-saf-fs.cpp
+backends/fs/android/android-saf-fs.h
 backends/graphics/opengl/opengl-graphics.cpp
 backends/graphics/openglsdl/openglsdl-graphics.cpp
 backends/graphics/surfacesdl/surfacesdl-graphics.cpp