[Scummvm-git-logs] scummvm branch-2-7 -> 81fecf557c9542b94ec6a7ee0e311e1c7e9d46a2

[lephilousophe]

This automated email contains information about 2 new commits which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
2847ba5bbe BACKENDS: OPENGL: Clear screen using opaque black instead of transparent
81fecf557c ANDROID: Fix glClearColor call


Commit: 2847ba5bbeb34d3d31e688cfc3a95d632852d03e
    https://github.com/scummvm/scummvm/commit/2847ba5bbeb34d3d31e688cfc3a95d632852d03e
Author: Le Philousophe (lephilousophe at users.noreply.github.com)
Date: 2023-07-01T11:20:44+02:00

Commit Message:
BACKENDS: OPENGL: Clear screen using opaque black instead of transparent

This looks like an overlook since the creation of the backend.
Previous Android backend used this and it shouldn't harm other
platforms.
This should fix a bug on ChromeOS.

Changed paths:
    backends/graphics/opengl/opengl-graphics.cpp


diff --git a/backends/graphics/opengl/opengl-graphics.cpp b/backends/graphics/opengl/opengl-graphics.cpp
index 035937d7b0d..9141416572a 100644
--- a/backends/graphics/opengl/opengl-graphics.cpp
+++ b/backends/graphics/opengl/opengl-graphics.cpp
@@ -1221,8 +1221,8 @@ void OpenGLGraphicsManager::notifyContextCreate(ContextType type,
 
 	// Setup backbuffer state.
 
-	// Default to black as clear color.
-	_backBuffer.setClearColor(0.0f, 0.0f, 0.0f, 0.0f);
+	// Default to opaque black as clear color.
+	_backBuffer.setClearColor(0.0f, 0.0f, 0.0f, 1.0f);
 
 	_pipeline->setFramebuffer(&_backBuffer);
 


Commit: 81fecf557c9542b94ec6a7ee0e311e1c7e9d46a2
    https://github.com/scummvm/scummvm/commit/81fecf557c9542b94ec6a7ee0e311e1c7e9d46a2
Author: Le Philousophe (lephilousophe at users.noreply.github.com)
Date: 2023-07-01T11:20:57+02:00

Commit Message:
ANDROID: Fix glClearColor call

This function takes floats between 0 and 1 and not integers

Changed paths:
    backends/graphics3d/android/android-graphics3d.cpp


diff --git a/backends/graphics3d/android/android-graphics3d.cpp b/backends/graphics3d/android/android-graphics3d.cpp
index 73e496253d2..94065f7050e 100644
--- a/backends/graphics3d/android/android-graphics3d.cpp
+++ b/backends/graphics3d/android/android-graphics3d.cpp
@@ -966,7 +966,7 @@ void AndroidGraphics3dManager::clearScreen(FixupType type, byte count) {
 
 	for (byte i = 0; i < count; ++i) {
 		// clear screen
-		GLCALL(glClearColor(0, 0, 0, 1 << 16));
+		GLCALL(glClearColor(0.f, 0.f, 0.f, 1.f));
 		GLCALL(glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT | GL_STENCIL_BUFFER_BIT));
 
 		switch (type) {