[Scummvm-git-logs] scummvm master -> 6d4544c13c8596df4ab2a6793d40fff3d3e15e0e

sev- noreply at scummvm.org
Wed Jul 26 21:37:16 UTC 2023


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
6d4544c13c DIRECTOR: Fix black patches in meet-media band


Commit: 6d4544c13c8596df4ab2a6793d40fff3d3e15e0e
    https://github.com/scummvm/scummvm/commit/6d4544c13c8596df4ab2a6793d40fff3d3e15e0e
Author: Harishankar Kumar (hari01584 at gmail.com)
Date: 2023-07-26T23:37:12+02:00

Commit Message:
DIRECTOR: Fix black patches in meet-media band

It has been observed that for `Shape` cast members, the default color
is white, as there were no foreColor in frames data for white fore-color
casts. This indicates  how director saves more memory by omitting this
foreColor(255).

`mediaband-win` used several of transparent white rectangle shape
cast to identify hover and click events. Using lingo `rollOver` command
However these shapes were set foreColor white which was not being
embedded in frames data. This caused the shapes to be rendered black
which is default foreColor.

--start-movie="intro.dxr" mediaband-win

Changed paths:
    engines/director/sprite.cpp


diff --git a/engines/director/sprite.cpp b/engines/director/sprite.cpp
index c0cd91bb341..5a63d9c5c68 100644
--- a/engines/director/sprite.cpp
+++ b/engines/director/sprite.cpp
@@ -65,7 +65,7 @@ Sprite::Sprite(Frame *frame) {
 	_autoPuppet = kAPNone; // Based on Director in a Nutshell, page 15
 	_immediate = false;
 	_backColor = g_director->_wm->_colorWhite;
-	_foreColor = g_director->_wm->_colorBlack;
+	_foreColor = g_director->_wm->_colorWhite;
 
 	_volume = 0;
 	_stretch = 0;




More information about the Scummvm-git-logs mailing list