[Scummvm-git-logs] scummvm master -> 6ee040ee551b301067eccf53cad69f860b8e9d52

[lephilousophe]

This automated email contains information about 2 new commits which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
a95f42317c BACKENDS: OPENGL: Clear screen using opaque black instead of transparent
6ee040ee55 ANDROID: Fix glClearColor call


Commit: a95f42317c589d07a8f60b136bda7a2040a19725
    https://github.com/scummvm/scummvm/commit/a95f42317c589d07a8f60b136bda7a2040a19725
Author: Le Philousophe (lephilousophe at users.noreply.github.com)
Date: 2023-06-04T18:22:59+02:00

Commit Message:
BACKENDS: OPENGL: Clear screen using opaque black instead of transparent

This looks like an overlook since the creation of the backend.
Previous Android backend used this and it shouldn't harm other
platforms.
This should fix a bug on ChromeOS.

Changed paths:
    backends/graphics/opengl/opengl-graphics.cpp


diff --git a/backends/graphics/opengl/opengl-graphics.cpp b/backends/graphics/opengl/opengl-graphics.cpp
index ddca6f346d1..7e4177ce221 100644
--- a/backends/graphics/opengl/opengl-graphics.cpp
+++ b/backends/graphics/opengl/opengl-graphics.cpp
@@ -1360,8 +1360,8 @@ void OpenGLGraphicsManager::notifyContextCreate(ContextType type,
 
 	// Setup backbuffer state.
 
-	// Default to black as clear color.
-	_backBuffer.setClearColor(0.0f, 0.0f, 0.0f, 0.0f);
+	// Default to opaque black as clear color.
+	_backBuffer.setClearColor(0.0f, 0.0f, 0.0f, 1.0f);
 
 	_pipeline->setFramebuffer(&_backBuffer);
 


Commit: 6ee040ee551b301067eccf53cad69f860b8e9d52
    https://github.com/scummvm/scummvm/commit/6ee040ee551b301067eccf53cad69f860b8e9d52
Author: Le Philousophe (lephilousophe at users.noreply.github.com)
Date: 2023-06-04T18:22:59+02:00

Commit Message:
ANDROID: Fix glClearColor call

This function takes floats between 0 and 1 and not integers

Changed paths:
    backends/graphics3d/android/android-graphics3d.cpp


diff --git a/backends/graphics3d/android/android-graphics3d.cpp b/backends/graphics3d/android/android-graphics3d.cpp
index 4e7f3e36e8c..a48630a7f91 100644
--- a/backends/graphics3d/android/android-graphics3d.cpp
+++ b/backends/graphics3d/android/android-graphics3d.cpp
@@ -969,7 +969,7 @@ void AndroidGraphics3dManager::clearScreen(FixupType type, byte count) {
 
 	for (byte i = 0; i < count; ++i) {
 		// clear screen
-		GLCALL(glClearColor(0, 0, 0, 1 << 16));
+		GLCALL(glClearColor(0.f, 0.f, 0.f, 1.f));
 		GLCALL(glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT | GL_STENCIL_BUFFER_BIT));
 
 		switch (type) {