[Scummvm-git-logs] scummvm master -> 4201e4562f7fee9d75284087a19c74330fdfc9a7

elasota noreply at scummvm.org
Sun Jun 11 21:05:45 UTC 2023


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
4201e4562f VCRUISE: Fix memory and file handle leak


Commit: 4201e4562f7fee9d75284087a19c74330fdfc9a7
    https://github.com/scummvm/scummvm/commit/4201e4562f7fee9d75284087a19c74330fdfc9a7
Author: elasota (ejlasota at gmail.com)
Date: 2023-06-11T17:05:33-04:00

Commit Message:
VCRUISE: Fix memory and file handle leak

Changed paths:
    engines/vcruise/runtime.cpp


diff --git a/engines/vcruise/runtime.cpp b/engines/vcruise/runtime.cpp
index 0b520009b39..0932d7d3368 100644
--- a/engines/vcruise/runtime.cpp
+++ b/engines/vcruise/runtime.cpp
@@ -2714,18 +2714,6 @@ Common::SharedPtr<SoundInstance> Runtime::loadWave(const Common::String &soundNa
 			return activeSound;
 	}
 
-	Common::SeekableReadStream *stream = archiveMemberPtr->createReadStream();
-	if (!stream) {
-		warning("Couldn't open read stream for sound '%s'", soundName.c_str());
-		return nullptr;
-	}
-
-	Audio::SeekableAudioStream *audioStream = Audio::makeWAVStream(stream, DisposeAfterUse::YES);
-	if (!audioStream) {
-		warning("Couldn't open audio stream for sound '%s'", soundName.c_str());
-		return nullptr;
-	}
-
 	Common::SharedPtr<SoundInstance> soundInstance(new SoundInstance());
 
 	soundInstance->name = soundName;




More information about the Scummvm-git-logs mailing list