[Scummvm-git-logs] scummvm master -> aa2b1beeceecfe26e1c4871b5e86f25abafbaaec

[dreammaster]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
aa2b1beece MM: MM1: Fix out-of-bounds read on drawing stats


Commit: aa2b1beeceecfe26e1c4871b5e86f25abafbaaec
    https://github.com/scummvm/scummvm/commit/aa2b1beeceecfe26e1c4871b5e86f25abafbaaec
Author: PushmePullyu (127053144+PushmePullyu at users.noreply.github.com)
Date: 2023-06-18T17:13:05-07:00

Commit Message:
MM: MM1: Fix out-of-bounds read on drawing stats

Changed paths:
    engines/mm/mm1/views_enh/character_info.cpp


diff --git a/engines/mm/mm1/views_enh/character_info.cpp b/engines/mm/mm1/views_enh/character_info.cpp
index 2302c0b031f..1295af1293a 100644
--- a/engines/mm/mm1/views_enh/character_info.cpp
+++ b/engines/mm/mm1/views_enh/character_info.cpp
@@ -280,7 +280,6 @@ void CharacterInfo::drawStats() {
 		if (i < 10)
 			pt.x += 8 + (CURR[i] < 10 ? 8 : 0);
 
-		setTextColor(c.statColor(CURR[i], BASE[i]));
 
 		if (i == 16) {
 			// Food
@@ -291,6 +290,7 @@ void CharacterInfo::drawStats() {
 			setTextColor(15);
 			writeString(pt.x, pt.y, str);
 		} else {
+			setTextColor(c.statColor(CURR[i], BASE[i]));
 			writeNumber(pt.x, pt.y, CURR[i]);
 		}
 	}