[Scummvm-git-logs] scummvm master -> e689c5116f1bc003b52e9fa9f246effc9a926c57

AndywinXp noreply at scummvm.org
Fri Mar 17 17:40:20 UTC 2023


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
e689c5116f SCUMM: GUI: Fix text not being entirely cleared in edge cases


Commit: e689c5116f1bc003b52e9fa9f246effc9a926c57
    https://github.com/scummvm/scummvm/commit/e689c5116f1bc003b52e9fa9f246effc9a926c57
Author: AndywinXp (andywinxp at gmail.com)
Date: 2023-03-17T18:40:13+01:00

Commit Message:
SCUMM: GUI: Fix text not being entirely cleared in edge cases

When clearBanner() is called for versions lower than 7, it can cause some pixels
from the previous dialog text to remain on screen and not be cleared when the
text speed banner is displayed and cleared out.

Changed paths:
    engines/scumm/input.cpp


diff --git a/engines/scumm/input.cpp b/engines/scumm/input.cpp
index 79cd32ee7e8..cd756e6eb70 100644
--- a/engines/scumm/input.cpp
+++ b/engines/scumm/input.cpp
@@ -1056,7 +1056,9 @@ void ScummEngine::processKeyboard(Common::KeyState lastKeyHit) {
 				bool leftBtnPressed = false, rightBtnPressed = false;
 				waitForBannerInput(60, ks, leftBtnPressed, rightBtnPressed);
 			} while (ks.ascii == '+' || ks.ascii == '-');
-			clearBanner();
+
+			if (_game.version > 6)
+				clearBanner();
 
 			pt.clear();
 




More information about the Scummvm-git-logs mailing list