[Scummvm-git-logs] scummvm branch-2-7 -> 1fe76bcdc6ecffc3c9f6d97e82645a2c48c097f7

AndywinXp noreply at scummvm.org
Fri Mar 17 17:45:01 UTC 2023


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
1fe76bcdc6 SCUMM: GUI: Fix text not being entirely cleared in edge cases


Commit: 1fe76bcdc6ecffc3c9f6d97e82645a2c48c097f7
    https://github.com/scummvm/scummvm/commit/1fe76bcdc6ecffc3c9f6d97e82645a2c48c097f7
Author: AndywinXp (andywinxp at gmail.com)
Date: 2023-03-17T18:43:17+01:00

Commit Message:
SCUMM: GUI: Fix text not being entirely cleared in edge cases

When clearBanner() is called for versions lower than 7, it can cause some pixels
from the previous dialog text to remain on screen and not be cleared when the
text speed banner is displayed and cleared out.

Changed paths:
    engines/scumm/input.cpp


diff --git a/engines/scumm/input.cpp b/engines/scumm/input.cpp
index ac99925d29d..332da4ae734 100644
--- a/engines/scumm/input.cpp
+++ b/engines/scumm/input.cpp
@@ -1037,7 +1037,9 @@ void ScummEngine::processKeyboard(Common::KeyState lastKeyHit) {
 				bool leftBtnPressed = false, rightBtnPressed = false;
 				waitForBannerInput(60, ks, leftBtnPressed, rightBtnPressed);
 			} while (ks.ascii == '+' || ks.ascii == '-');
-			clearBanner();
+
+			if (_game.version > 6)
+				clearBanner();
 
 			pt.clear();
 




More information about the Scummvm-git-logs mailing list