[Scummvm-git-logs] scummvm master -> 3c7b7b4a724271a539dae794513d41a06fdb517b

sdelamarre noreply at scummvm.org
Thu Mar 23 22:54:38 UTC 2023


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
3c7b7b4a72 GOB: do not prefix anymore opcodeDraw and opcodeGoblin by script offset in debug traces


Commit: 3c7b7b4a724271a539dae794513d41a06fdb517b
    https://github.com/scummvm/scummvm/commit/3c7b7b4a724271a539dae794513d41a06fdb517b
Author: Simon Delamarre (simon.delamarre14 at gmail.com)
Date: 2023-03-23T23:54:08+01:00

Commit Message:
GOB: do not prefix anymore opcodeDraw and opcodeGoblin by script offset in debug traces

Those codes are always preceded by a o1_drawOperations/o1_goblinFunc, whose offset is already printed. That way, we only print offsets at the beginning of an OpcodeFunc, which helps mirroring our debug traces with "degob" output from scummvm-tools.

Changed paths:
    engines/gob/inter.cpp


diff --git a/engines/gob/inter.cpp b/engines/gob/inter.cpp
index c78a7d2d322..2f458ccdddc 100644
--- a/engines/gob/inter.cpp
+++ b/engines/gob/inter.cpp
@@ -68,8 +68,7 @@ void Inter::setupOpcodes() {
 }
 
 void Inter::executeOpcodeDraw(byte i) {
-	debugC(1, kDebugDrawOp, "%s:%08d: opcodeDraw %d [0x%X] (%s)",
-		   _vm->_game->_curTotFile.c_str(), _vm->_game->_script->pos(), i, i, getDescOpcodeDraw(i));
+	debugC(1, kDebugDrawOp, "opcodeDraw %d [0x%X] (%s)", i, i, getDescOpcodeDraw(i));
 
 	if (_opcodesDraw[i].proc && _opcodesDraw[i].proc->isValid())
 		(*_opcodesDraw[i].proc)();
@@ -89,8 +88,8 @@ void Inter::executeOpcodeFunc(byte i, byte j, OpFuncParams &params) {
 }
 
 void Inter::executeOpcodeGob(int i, OpGobParams &params) {
-	debugC(1, kDebugGobOp, "%s:%08d: opcodeGoblin %d [0x%X] (%s)",
-		   _vm->_game->_curTotFile.c_str(), _vm->_game->_script->pos(), i, i, getDescOpcodeGob(i));
+	debugC(1, kDebugGobOp, "opcodeGoblin %d [0x%X] (%s)",
+			i, i, getDescOpcodeGob(i));
 
 	OpcodeEntry<OpcodeGob> *op = nullptr;
 




More information about the Scummvm-git-logs mailing list